From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all symbol
Date: Thu, 15 Sep 2022 12:44:22 -0700
Message-ID: <20220915194422.bbdzwo7gmcvwzv4b@awork3.anarazel.de> (raw)
In-Reply-To: <2490844.1663123546@sss.pgh.pa.us>
References: <325593.1662783266@sss.pgh.pa.us>
<89D645BA-FF97-4516-A21D-9FC4A4B31F8C@anarazel.de>
<20220910043749.koidc5k4j5dxo3if@awork3.anarazel.de>
<20220910052741.t7w7csyrggwus2ze@awork3.anarazel.de>
<338810.1662787972@sss.pgh.pa.us>
<20220910055736.htsr5juo3ldlay2l@awork3.anarazel.de>
<20220910081944.oiayp5lky3kv2o43@awork3.anarazel.de>
<20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de>
<20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de>
<2490844.1663123546@sss.pgh.pa.us>
Hi,
On 2022-09-13 22:45:46 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > So we could work around the xlc 12.1 issue with something like the attached
> > patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will
> > have to wait a while to see more
>
> Shouldn't that be more like
>
> + if test "$pgac_cv_prog_CC_cflags__qvisibility_hidden" != "yes"; then
> + CFLAGS_SL_MODULE='$CFLAGS_SL_MODULE -Wl,-b,expfull'
> + fi
>
> to avoid losing whatever we found out before that?
Yes, you're right. There's nothing today, but we shouldn't assume that.
> > I think it'd be considerably better to just not support xlc < 13.1 though.
>
> A three-line patch doesn't seem like an unreasonable thing to carry,
> at least till these systems go out of support. We've jumped through
> much higher hoops in the past to support niche platforms.
xlc 12.1 *is* out of support and there's a newer compiler installed.
The amount of lines itself doesn't bother me. What does is that it makes an
already complicated platform more complicated: All symbols from extension
.so's are exported, but only for old and unsupported versions of the
proprietary compiler.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all symbol
In-Reply-To: <20220915194422.bbdzwo7gmcvwzv4b@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox