pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: instr_time: Represent time as an int64 on all platforms
Date: Mon, 23 Jan 2023 09:16:28 -0800
Message-ID: <20230123171628.qhteecrag4pite6v@awork3.anarazel.de> (raw)
In-Reply-To: <1543364.1674456919@sss.pgh.pa.us>
References: <E1pJ6NT-004jOH-DF@gemulon.postgresql.org>
	<Y84ZfhnTWJThOhUO@paquier.xyz>
	<1540079.1674454854@sss.pgh.pa.us>
	<20230123064647.tzxnmql2xkegc7sw@awork3.anarazel.de>
	<1543364.1674456919@sss.pgh.pa.us>

Hi,

On 2023-01-23 01:55:19 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2023-01-23 01:20:54 -0500, Tom Lane wrote:
> >> Yeah, there was some discussion about that already:
> >> https://www.postgresql.org/message-id/20230121190303.7xjiwdg3gvb62lu3@awork3.anarazel.de
> 
> > I was thinking of starting a starting a separate thread about it - it's
> > mostly a plpython issue, the fact that my commit caused the compilation
> > failure is somewhat random.
> 
> True.  It also seems odd to me that per your analysis, we fixed
> the _POSIX_C_SOURCE conflict on 4 Aug 2011 and then broke it again
> on 18 Dec 2011, yet nobody has noticed for nigh a dozen years ---
> there has to be some other element in there.

Well, we didn't *fully* break - all the system library headers included via
postgres.h are still included first. It's "just" stuff like <time.h>, that are
included later / indirectly, where we broke it. It's not too hard to believe
that changing _POSIX_C_SOURCE won't cause immediately visible problems oustide
of a few headers that we already included via c.h.

Greetings,

Andres Freund





view thread (7+ messages)  latest in thread

Message-ID: <20230123171628.qhteecrag4pite6v@awork3.anarazel.de>
Permalink:  ../20230123171628.qhteecrag4pite6v@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230123171628.qhteecrag4pite6v@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, michael@paquier.xyz
  Subject: Re: pgsql: instr_time: Represent time as an int64 on all platforms
  In-Reply-To: <20230123171628.qhteecrag4pite6v@awork3.anarazel.de>
  References: <E1pJ6NT-004jOH-DF@gemulon.postgresql.org> <Y84ZfhnTWJThOhUO@paquier.xyz> <1540079.1674454854@sss.pgh.pa.us> <20230123064647.tzxnmql2xkegc7sw@awork3.anarazel.de> <1543364.1674456919@sss.pgh.pa.us> <20230123171628.qhteecrag4pite6v@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox