pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module
Date: Wed, 25 Jan 2023 13:34:51 -0800
Message-ID: <20230125213451.GA1100929@nathanxps13> (raw)
In-Reply-To: <CA+TgmoY4WTkFNHZjSSjjjOSUyjHzatwMp+DVWK3W-A=h5+AQzQ@mail.gmail.com>
References: <E1pKYTE-005MZS-WB@gemulon.postgresql.org>
	<CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com>
	<20230125181750.GC1098626@nathanxps13>
	<CA+TgmoY4WTkFNHZjSSjjjOSUyjHzatwMp+DVWK3W-A=h5+AQzQ@mail.gmail.com>

On Wed, Jan 25, 2023 at 02:05:39PM -0500, Robert Haas wrote:
> On Wed, Jan 25, 2023 at 1:17 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> I wanted to merge basic_archive and basic_recovery because there's a decent
>> chunk of duplicated code.  Perhaps that is okay, but I would rather just
>> have one test module.  AFAICT the biggest reason to split it is because we
>> can't determine a good name.  Maybe we could leave the name as
>> "basic_archive" since it deals with creating and recovering archive files.
> 
> Yeah, maybe. I'm not sure what the best thing to do is, but if I see a
> module called basic_archive or basic_restore, I know what it's about,
> whereas basic_wal_module seems a lot less specific. It sounds like it
> could be generating or streaming it just as easily as it could be
> archiving it. It would be nice to have a name that is less prone to
> that kind of unclarity.

Good point.  It seems like the most straightforward approach is just to
have separate modules.  Unless Michael objects, I'll go that route.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (10+ messages)  latest in thread

Message-ID: <20230125213451.GA1100929@nathanxps13>
Permalink:  ../20230125213451.GA1100929@nathanxps13/
Also on:    postgresql.org/message-id/20230125213451.GA1100929@nathanxps13

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: nathandbossart@gmail.com, robertmhaas@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module
  In-Reply-To: <20230125213451.GA1100929@nathanxps13>
  References: <E1pKYTE-005MZS-WB@gemulon.postgresql.org> <CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com> <20230125181750.GC1098626@nathanxps13> <CA+TgmoY4WTkFNHZjSSjjjOSUyjHzatwMp+DVWK3W-A=h5+AQzQ@mail.gmail.com> <20230125213451.GA1100929@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox