From: Andres Freund <andres@anarazel.de>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow logical decoding on standbys
Date: Wed, 12 Apr 2023 11:10:00 -0700
Message-ID: <20230412181000.sk67iouifwhnhhkh@awork3.anarazel.de> (raw)
In-Reply-To: <20230412174244.6njadz4uoiez3l74@awork3.anarazel.de>
References: <E1pl4qQ-0021HA-Bw@gemulon.postgresql.org>
<20230411.120253.579856734111967616.horikyota.ntt@gmail.com>
<20230412174244.6njadz4uoiez3l74@awork3.anarazel.de>
Hi,
On 2023-04-12 10:42:44 -0700, Andres Freund wrote:
> On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote:
> > > Allow logical decoding on standbys
> >
> > This adds the following error message.
> >
> > + errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary")));
> >
> > We alredy have a nearly identical message as follows.
> >
> > > errmsg("logical decoding requires wal_level >= logical")));
> >
> > And we used to writte this kind of conditions, like "wal_level >=
> > logical", using a mathematical operator. Don't we need to unify them?
>
> I guess. It doesn't seem particularly important, but why not.
If we do that, we should adjust the errdetail() that you (correctly!) pointed
out as needing punctuation as well. Pushed those improvements together.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, horikyota.ntt@gmail.com
Subject: Re: pgsql: Allow logical decoding on standbys
In-Reply-To: <20230412181000.sk67iouifwhnhhkh@awork3.anarazel.de>
References: <E1pl4qQ-0021HA-Bw@gemulon.postgresql.org> <20230411.120253.579856734111967616.horikyota.ntt@gmail.com> <20230412174244.6njadz4uoiez3l74@awork3.anarazel.de> <20230412181000.sk67iouifwhnhhkh@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox