pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic
Date: Sat, 14 Oct 2023 18:36:07 -0700
Message-ID: <20231015013607.61@rfd.leadboat.com> (raw)
In-Reply-To: <1980111.1697329678@sss.pgh.pa.us>
References: <E1qroAX-000arw-0A@gemulon.postgresql.org>
	<1974777.1697327121@sss.pgh.pa.us>
	<20231015000358.2d@rfd.leadboat.com>
	<1980111.1697329678@sss.pgh.pa.us>

On Sat, Oct 14, 2023 at 08:27:58PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Sat, Oct 14, 2023 at 07:45:21PM -0400, Tom Lane wrote:
> >> Hmm, I'm not sure that that last is a good idea.  The upshot of this
> >> (because of the opr_sanity.out change) is that "make installcheck"
> >> will fail against existing back-branch installations.  That seems
> >> more likely to cause problems/confusion than the alternative of just
> >> depending on the code change.
> 
> > I'm way more worried about amcheck failing on all those indexes than I am
> > about someone who needs to tweak their installcheck rig.
> 
> Well, that's indeed going to be a pain for affected people, but
> it doesn't seem like a reason to also break installcheck.

That's right.  We don't have a standard that installcheck of v13.N will have
zero diffs on an initdb from v13.0.  Zero diffs would be help a tiny user
population, and corrected catalog entries will help a different population.  I
don't think either choice does enough harm to reopen the decision.  We've got
bigger fish to fry.





view thread (13+ messages)  latest in thread

Message-ID: <20231015013607.61@rfd.leadboat.com>
Permalink:  ../20231015013607.61@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20231015013607.61@rfd.leadboat.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic
  In-Reply-To: <20231015013607.61@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox