From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move I/O before the index_update_stats() buffer lock region.
Date: Sat, 2 Nov 2024 20:10:27 -0700
Message-ID: <20241103031027.09.nmisch@google.com> (raw)
In-Reply-To: <2317336.1730601176@sss.pgh.pa.us>
References: <E1t7GgB-003cVa-Th@gemulon.postgresql.org>
<2317336.1730601176@sss.pgh.pa.us>
On Sat, Nov 02, 2024 at 10:32:56PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > Move I/O before the index_update_stats() buffer lock region.
>
> In branches before 17, this commit is causing some compilers
> to complain:
>
> index.c: In function 'index_update_stats':
> index.c:2913:24: warning: 'relpages' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (rd_rel->relpages != (int32) relpages)
> ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
>
> I'm seeing that with RHEL8's gcc 8.5.0, and trawling the buildfarm
> shows at least 40 animals similarly unhappy. (I noticed this because
> mamba, which is using -Werror, is actually failing.)
Hopefully now the code won't fool any compiler.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move I/O before the index_update_stats() buffer lock region.
In-Reply-To: <20241103031027.09.nmisch@google.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox