pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: pg_createsubscriber: Fix error complaining about the wrong thing
6+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2025-11-06 83122538f2 726e77d7a9 150e24501b Fix redundancy in error message
* pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
@ 2025-10-31 17:08 Álvaro Herrera <alvherre@kurilemu.de>
2025-11-04 10:40 ` Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 6+ messages in thread
From: Álvaro Herrera @ 2025-10-31 17:08 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pg_createsubscriber: Fix error complaining about the wrong thing
The code updates the system identifier, then runs pg_walreset; if the
latter fails, it complains about the former, which makes no sense.
Change the error message to complain about the right thing.
Noticed while reviewing a patch touching nearby code.
Author: Álvaro Herrera <alvherre@kurilemu.de>
Backpatch-through: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/11144915e101eff94556192f5f18f6ac133da43e
Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
2025-10-31 17:08 pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Álvaro Herrera <alvherre@kurilemu.de>
@ 2025-11-04 10:40 ` Peter Eisentraut <peter@eisentraut.org>
2025-11-06 09:56 ` Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 6+ messages in thread
From: Peter Eisentraut @ 2025-11-04 10:40 UTC (permalink / raw)
To: Álvaro Herrera <alvherre@kurilemu.de>; pgsql-committers@lists.postgresql.org
On 31.10.25 18:08, Álvaro Herrera wrote:
> pg_createsubscriber: Fix error complaining about the wrong thing
>
> The code updates the system identifier, then runs pg_walreset; if the
> latter fails, it complains about the former, which makes no sense.
> Change the error message to complain about the right thing.
- pg_log_info("subscriber successfully changed the system identifier");
+ pg_log_info("subscriber successfully reset WAL on the subscriber");
Maybe that message has one "subscriber" too many?
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
2025-10-31 17:08 pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Álvaro Herrera <alvherre@kurilemu.de>
2025-11-04 10:40 ` Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Peter Eisentraut <peter@eisentraut.org>
@ 2025-11-06 09:56 ` Peter Eisentraut <peter@eisentraut.org>
2025-11-06 12:57 ` Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 1 reply; 6+ messages in thread
From: Peter Eisentraut @ 2025-11-06 09:56 UTC (permalink / raw)
To: Álvaro Herrera <alvherre@kurilemu.de>; pgsql-committers@lists.postgresql.org
On 04.11.25 11:40, Peter Eisentraut wrote:
> On 31.10.25 18:08, Álvaro Herrera wrote:
>> pg_createsubscriber: Fix error complaining about the wrong thing
>>
>> The code updates the system identifier, then runs pg_walreset; if the
>> latter fails, it complains about the former, which makes no sense.
>> Change the error message to complain about the right thing.
>
> - pg_log_info("subscriber successfully changed the system identifier");
> + pg_log_info("subscriber successfully reset WAL on the subscriber");
>
> Maybe that message has one "subscriber" too many?
I have fixed this.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
2025-10-31 17:08 pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Álvaro Herrera <alvherre@kurilemu.de>
2025-11-04 10:40 ` Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Peter Eisentraut <peter@eisentraut.org>
2025-11-06 09:56 ` Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Peter Eisentraut <peter@eisentraut.org>
@ 2025-11-06 12:57 ` Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 6+ messages in thread
From: Álvaro Herrera @ 2025-11-06 12:57 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org
On 2025-Nov-06, Peter Eisentraut wrote:
> On 04.11.25 11:40, Peter Eisentraut wrote:
> > Maybe that message has one "subscriber" too many?
>
> I have fixed this.
Thanks.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"I can see support will not be a problem. 10 out of 10." (Simon Wittber)
(http://archives.postgresql.org/pgsql-general/2004-12/msg00159.php)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
@ 2025-10-31 17:08 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 6+ messages in thread
From: Álvaro Herrera @ 2025-10-31 17:08 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pg_createsubscriber: Fix error complaining about the wrong thing
The code updates the system identifier, then runs pg_walreset; if the
latter fails, it complains about the former, which makes no sense.
Change the error message to complain about the right thing.
Noticed while reviewing a patch touching nearby code.
Author: Álvaro Herrera <alvherre@kurilemu.de>
Backpatch-through: 17
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/59aeb693f67fc15dfa58e2fdada2a70ce1004660
Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
@ 2025-10-31 17:08 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 6+ messages in thread
From: Álvaro Herrera @ 2025-10-31 17:08 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pg_createsubscriber: Fix error complaining about the wrong thing
The code updates the system identifier, then runs pg_walreset; if the
latter fails, it complains about the former, which makes no sense.
Change the error message to complain about the right thing.
Noticed while reviewing a patch touching nearby code.
Author: Álvaro Herrera <alvherre@kurilemu.de>
Backpatch-through: 17
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/14044eb25866113147ae82631f1e9259e5317cae
Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-11-06 12:57 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-10-31 17:08 pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Álvaro Herrera <alvherre@kurilemu.de>
2025-11-04 10:40 ` Peter Eisentraut <peter@eisentraut.org>
2025-11-06 09:56 ` Peter Eisentraut <peter@eisentraut.org>
2025-11-06 12:57 ` Álvaro Herrera <alvherre@kurilemu.de>
2025-10-31 17:08 pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Álvaro Herrera <alvherre@kurilemu.de>
2025-10-31 17:08 pgsql: pg_createsubscriber: Fix error complaining about the wrong thing Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox