agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
Date: Fri, 19 Jul 2019 14:56:34 -0400
Message-ID: <2143.1563562594@sss.pgh.pa.us> (raw)
In-Reply-To: <31996.1563509161@sss.pgh.pa.us>
References: <E1hnsNp-0007u8-PD@gemulon.postgresql.org>
<20190719035347.GJ1859@paquier.xyz>
<31996.1563509161@sss.pgh.pa.us>
I wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> This is causing a compilation warning on Windows:
> ...so I think your compiler has a point. I shall complain to upstream.
The IANA folk want to fix it like this:
diff --git a/zic.c b/zic.c
index 8bf5628..a84703a 100644
--- a/zic.c
+++ b/zic.c
@@ -2145,7 +2145,7 @@ writezone(const char *const name, const char *const string, char version,
}
if (pass == 1 && !want_bloat()) {
utcnt = stdcnt = thisleapcnt = 0;
- thistimecnt = - locut - hicut;
+ thistimecnt = - (locut + hicut);
thistypecnt = thischarcnt = 1;
thistimelim = thistimei;
}
I'm not quite convinced whether that will silence the warning, but
at least it's a bit less unreadable.
regards, tom lane
view thread (104+ messages) latest in thread
Message-ID: <2143.1563562594@sss.pgh.pa.us>
Permalink: ../2143.1563562594@sss.pgh.pa.us/
Also on: postgresql.org/message-id/2143.1563562594@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
In-Reply-To: <2143.1563562594@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox