From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
Date: Sat, 12 Nov 2016 11:30:42 -0500
Message-ID: <22432.1478968242@sss.pgh.pa.us> (raw)
In-Reply-To: <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de>
References: <E1aRRgI-00022x-UD@gemulon.postgresql.org>
<20160826220026.2fw6xj56qgd22wqi@alap3.anarazel.de>
<CA+TgmoYmHD8CdW+8yh6A=i29Co-2xiiH3YBdBRxKFZ8TqP0V8A@mail.gmail.com>
<CAA4eK1LaN1xXRgo2BxQGLYoXeNaQTZOoFOf6Qi19WfZkknZKgg@mail.gmail.com>
<20160830023140.tsesenk7roajx3ak@alap3.anarazel.de>
<CAA4eK1JOjkdXYtHxh=2aDK4VgDtN-LNGKY_YqX0N=YEvuzQVWg@mail.gmail.com>
<CAA4eK1Jt5fYe2jnQ7XXDrpy3Z4W80UYhQa9SvCyXz+7mcoN8Gw@mail.gmail.com>
<CAE9k0P=tew0UXETJfM5WQjqNS0k7xYZEFWMZCY8ZuEqRSD1uUA@mail.gmail.com>
<CAA4eK1LJRtV=jBa46F6+=s7cf-x7ajFAraYBdAxaCjZ0m_FQ0w@mail.gmail.com>
<20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Andres Freund <andres@anarazel.de> writes:
> Committed after simplifying the Makefile.
While I have no particular objection to adding these tests, the
commit log's claim that this will improve buildfarm testing is
quite wrong. The buildfarm runs "make installcheck" not
"make check" in contrib. What I'm actually seeing in the
buildfarm reports is
make -C pg_stat_statements installcheck
make -C ../../src/test/regress pg_regress
make -C ../../../src/port all
make -C ../backend submake-errcodes
make[4]: Nothing to be done for `submake-errcodes'.
make -C ../../../src/common all
make -C ../backend submake-errcodes
make[4]: Nothing to be done for `submake-errcodes'.
../../src/test/regress/pg_regress --inputdir=. --bindir='/Users/buildfarm/bf-data/HEAD/inst/bin' --port=5678 --temp-config ../../contrib/pg_stat_statements/pg_stat_statements.conf --dbname=contrib_regression_pg_stat_statements
(using postmaster on Unix socket, port 5678)
============== dropping database "contrib_regression_pg_stat_statements" ==============
NOTICE: database "contrib_regression_pg_stat_statements" does not exist, skipping
DROP DATABASE
============== creating database "contrib_regression_pg_stat_statements" ==============
CREATE DATABASE
ALTER DATABASE
============== running regression test queries ==============
=====================
All 0 tests passed.
=====================
which is a rather blatant waste of cycles. I would suggest an explicit
do-nothing installcheck rule rather than the hack you came up with here.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, amit.kapila16@gmail.com, ashu.coek88@gmail.com, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
In-Reply-To: <22432.1478968242@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox