From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Remove BufFile's isTemp flag.
Date: Thu, 16 Nov 2017 22:17:31 -0500
Message-ID: <24110.1510888651@sss.pgh.pa.us> (raw)
In-Reply-To: <20171117031149.hslkxis732hkjuog@alap3.anarazel.de>
References: <E1eFVyl-0008J1-RO@gemulon.postgresql.org>
<23339.1510887494@sss.pgh.pa.us>
<20171117031149.hslkxis732hkjuog@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2017-11-16 21:58:14 -0500, Tom Lane wrote:
>> [ squint... ] That used to have an actual purpose connected to
>> transaction-abort cleanup, IIRC. It disturbs me that this seems
>> to have been lost.
> I've not found any such use, searching through buffile.c's history. I
> don't quite see how that flag could've been related to abort cleanup
> stuff? There's been another unused caller of makeBufFile, namely
> BufFileCreate, that has been #ifdef'ed out for ages (perhaps we
> should've removed that with this commit or a long time ago). Other than
> that there seems to not have been any other caller setting that flag
> differently since you created the file in db3c4c3a2d980dcd.
I'm tired for today, but will take a closer look tomorrow. I do not
think the mechanism was created without a purpose ...
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
Subject: Re: pgsql: Remove BufFile's isTemp flag.
In-Reply-To: <24110.1510888651@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox