pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
Date: Sat, 12 Nov 2016 12:17:10 -0500
Message-ID: <25236.1478971030@sss.pgh.pa.us> (raw)
In-Reply-To: <20161112171225.eo5vm7cjfatufm6q@alap3.anarazel.de>
References: <CAA4eK1LaN1xXRgo2BxQGLYoXeNaQTZOoFOf6Qi19WfZkknZKgg@mail.gmail.com>
	<20160830023140.tsesenk7roajx3ak@alap3.anarazel.de>
	<CAA4eK1JOjkdXYtHxh=2aDK4VgDtN-LNGKY_YqX0N=YEvuzQVWg@mail.gmail.com>
	<CAA4eK1Jt5fYe2jnQ7XXDrpy3Z4W80UYhQa9SvCyXz+7mcoN8Gw@mail.gmail.com>
	<CAE9k0P=tew0UXETJfM5WQjqNS0k7xYZEFWMZCY8ZuEqRSD1uUA@mail.gmail.com>
	<CAA4eK1LJRtV=jBa46F6+=s7cf-x7ajFAraYBdAxaCjZ0m_FQ0w@mail.gmail.com>
	<20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de>
	<22432.1478968242@sss.pgh.pa.us>
	<20161112163508.5uqlaozeyr3l56ae@alap3.anarazel.de>
	<22899.1478968932@sss.pgh.pa.us>
	<20161112171225.eo5vm7cjfatufm6q@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
> On 2016-11-12 11:42:12 -0500, Tom Lane wrote:
>> Hm.  What about inventing an additional macro NO_INSTALLCHECK that
>> prevents pgxs.mk from generating an installcheck rule?

> That'd work. I'd also be ok with living with the warning.  I have to say
> I find it hard to be concerned about the cycles here. It's not like
> anybody complained about make check unconditionally creating a test
> installation, even if there's tests in a contrib module...

[ shrug... ]  The reason why the buildfarm doesn't do "make check" here is
precisely the extra cycles it would take.  Those add up over hundreds of
runs, particularly on slow machines.  So I'm not excited about running
completely useless operations.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (21+ messages)  latest in thread

Message-ID: <25236.1478971030@sss.pgh.pa.us>
Permalink:  ../25236.1478971030@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/25236.1478971030@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, amit.kapila16@gmail.com, ashu.coek88@gmail.com, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
  In-Reply-To: <25236.1478971030@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox