pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
Date: Sat, 12 Feb 2022 23:12:50 -0500
Message-ID: <2523849.1644725570@sss.pgh.pa.us> (raw)
In-Reply-To: <Ygh63xlK4p+mFB8T@paquier.xyz>
References: <E1nIWNg-0005L1-2v@gemulon.postgresql.org>
	<Ygc51WVAFGocSu4h@paquier.xyz>
	<CA+TgmoZWEjAPK3SHxGzvEPF9CAPTLUMvkZvU_jou8sNUx_gRNA@mail.gmail.com>
	<20220212220913.wnhgd7ak32srcmzo@alap3.anarazel.de>
	<CA+Tgmobva6NRLtp=8z3V8EzmwryOdfZwBy+8NUf8aQH5B9p-1A@mail.gmail.com>
	<2460218.1644704163@sss.pgh.pa.us>
	<Ygh63xlK4p+mFB8T@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> On Sat, Feb 12, 2022 at 05:16:03PM -0500, Tom Lane wrote:
>> I think adding an explicit PGAC_PATH_PROGS would be worth the cycles.

> Well, this somebody is I, and the buildfarm did not blow up on any of
> that so that looked rather fine.

Eh?  copperhead for one is failing for exactly this reason:

Bailout called.  Further testing stopped:  failed to execute command "lz4 -d -m /home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/server-backup/base.tar.lz4": No such file or directory

> Adding a few cycles for this check
> is fine by me.  What do you think of the attached?

Looks OK as far as it goes ... but do we need anything on the
MSVC side?

Also, I can't help wondering why we have both GZIP_PROGRAM and GZIP
variables.  I suppose that's a separate issue though.

			regards, tom lane





view thread (13+ messages)  latest in thread

Message-ID: <2523849.1644725570@sss.pgh.pa.us>
Permalink:  ../2523849.1644725570@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2523849.1644725570@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, robertmhaas@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
  In-Reply-To: <2523849.1644725570@sss.pgh.pa.us>
  References: <E1nIWNg-0005L1-2v@gemulon.postgresql.org> <Ygc51WVAFGocSu4h@paquier.xyz> <CA+TgmoZWEjAPK3SHxGzvEPF9CAPTLUMvkZvU_jou8sNUx_gRNA@mail.gmail.com> <20220212220913.wnhgd7ak32srcmzo@alap3.anarazel.de> <CA+Tgmobva6NRLtp=8z3V8EzmwryOdfZwBy+8NUf8aQH5B9p-1A@mail.gmail.com> <2460218.1644704163@sss.pgh.pa.us> <Ygh63xlK4p+mFB8T@paquier.xyz> <2523849.1644725570@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox