From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: Wed, 19 Jun 2019 17:35:48 -0400
Message-ID: <25314.1560980148@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoYF00U3Pbkh4mXhXr1NN6pKFM278KmXRS35HDuHgNcMFw@mail.gmail.com>
References: <24452.1560285699@sss.pgh.pa.us>
<20190614095546.GA15107@msg.df7cb.de>
<26948.1560517875@sss.pgh.pa.us>
<87ef3w3u8a.fsf@news-spur.riddles.org.uk>
<7114.1560539536@sss.pgh.pa.us>
<875zp74zpf.fsf@news-spur.riddles.org.uk>
<871rzv4yes.fsf@news-spur.riddles.org.uk>
<20190617173943.z3ttxqenbcwrlag4@alap3.anarazel.de>
<20190617183458.GG2480@tamriel.snowman.net>
<20190617183828.hj7ci362zbxd4nax@alap3.anarazel.de>
<20190617184053.GI2480@tamriel.snowman.net>
<CA+TgmoYF00U3Pbkh4mXhXr1NN6pKFM278KmXRS35HDuHgNcMFw@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Jun 17, 2019 at 2:41 PM Stephen Frost <sfrost@snowman.net> wrote:
>> Ah, ok, I agree that would have been good to do. Of course, hindsight
>> being 20/20 and all that. Something to keep in mind for the future
>> though.
> I think it was inappropriate to commit this at all. You can't just
> say "some other committer objects, but I think I'm right so I'll just
> ignore them and commit anyway." If we all do that it'll be chaos.
FWIW, that was my concern about this.
> I don't know exactly how many concurring vote it takes to override
> somebody else's -1, but it's got to be more than zero.
If even one other person had +1'd Andrew's proposal, I'd have yielded
to the consensus --- this was certainly an issue on which it's not
totally clear what to do. But unless I missed some traffic, the vote
was exactly 1 to 1. There is no way that that represents consensus to
commit.
Also on the topic of process: 48 hours before a wrap deadline is
*particularly* not the time to play fast and loose with this sort of
thing. It'd have been better to wait till after this week's releases,
so there'd at least be time to reconsider if the patch turned out to
have unexpected side-effects.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, sfrost@snowman.net, andres@anarazel.de, andrew@tao11.riddles.org.uk, myon@debian.org, pgsql-hackers@postgresql.org
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
In-Reply-To: <25314.1560980148@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox