pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add support for temporary replication slots
Date: Mon, 12 Dec 2016 10:55:44 -0500
Message-ID: <27833.1481558144@sss.pgh.pa.us> (raw)
In-Reply-To: <27274.1481557380@sss.pgh.pa.us>
References: <E1cGRP8-0003EH-So@gemulon.postgresql.org>
	<27274.1481557380@sss.pgh.pa.us>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

I wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> Add support for temporary replication slots

> Some of the slower buildfarm members are failing test-decoding-check since
> this went in.  At least on prairiedog, it looks like a race condition in
> the test:

Having now looked a bit more closely, that's almost certainly what it is:
the test is assuming that the old backend exits instantaneously, which
it doesn't.  You might want to borrow the wait-for-previous-session-to-die
loop I put into src/test/modules/test_extensions/sql/test_extensions.sql
recently.  (Make sure you get the fixed version ;-))

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (22+ messages)  latest in thread

Message-ID: <27833.1481558144@sss.pgh.pa.us>
Permalink:  ../27833.1481558144@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/27833.1481558144@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter_e@gmx.net
  Subject: Re: pgsql: Add support for temporary replication slots
  In-Reply-To: <27833.1481558144@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox