pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Petr Jelinek <petr.jelinek@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add support for temporary replication slots
Date: Thu, 15 Dec 2016 08:51:04 -0500
Message-ID: <a7315da5-fd22-bcbc-0541-8979a586284c@2ndquadrant.com> (raw)
In-Reply-To: <309c14fa-e043-a353-366e-3ce0aab527c8@2ndquadrant.com>
References: <27274.1481557380@sss.pgh.pa.us>
	<27833.1481558144@sss.pgh.pa.us>
	<62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com>
	<22907.1481571177@sss.pgh.pa.us>
	<15713.1481585953@sss.pgh.pa.us>
	<314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com>
	<18684.1481589637@sss.pgh.pa.us>
	<48b2c017-695d-b5ac-2ff4-89b939b3e8f9@2ndquadrant.com>
	<20161213004903.iito2pefdrrjgny5@alap3.anarazel.de>
	<6886c56a-f6c8-3c44-53a1-dae6c24afb76@2ndquadrant.com>
	<20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de>
	<a6b63bc4-ed38-2908-ef8d-1d96f2012d57@2ndquadrant.com>
	<3c8c413d-b476-93d2-652f-011a589a2d74@2ndquadrant.com>
	<309c14fa-e043-a353-366e-3ce0aab527c8@2ndquadrant.com>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

On 12/15/16 3:46 AM, Petr Jelinek wrote:
>>> Okay in case we decide it's the right way to go attached patch does
>>> that. I also added some more tests based on your feedback while I am at it.
>>
>> This looks mostly reasonable to me, but the location and xid output from
>> pg_logical_slot_get_changes() is not portable/repeatable, so it should
>> be omitted from the output.
>>
> 
> Sigh, yes you are right.

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (22+ messages)

Message-ID: <a7315da5-fd22-bcbc-0541-8979a586284c@2ndquadrant.com>
Permalink:  ../a7315da5-fd22-bcbc-0541-8979a586284c@2ndquadrant.com/
Also on:    postgresql.org/message-id/a7315da5-fd22-bcbc-0541-8979a586284c@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, petr.jelinek@2ndquadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Add support for temporary replication slots
  In-Reply-To: <a7315da5-fd22-bcbc-0541-8979a586284c@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox