pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: Damir Belyalov <dam.bel07@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor background psql TAP functions
Date: Tue, 16 May 2023 21:43:00 +0200
Message-ID: <27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org> (raw)
In-Reply-To: <CALH1Lgui397s_4AXWm1ZO_uCLOUVL1HAa0TO9CbdMy1kvokkzA@mail.gmail.com>
References: <E1pksad-001uk0-CL@gemulon.postgresql.org>
	<c0ba3008-dbc8-e53f-29f2-2e9abe72b2a2@enterprisedb.com>
	<34800305-E1E6-4194-8738-9977946DB12A@postgresql.org>
	<CALH1Lgui397s_4AXWm1ZO_uCLOUVL1HAa0TO9CbdMy1kvokkzA@mail.gmail.com>

> On 16 May 2023, at 21:04, Damir Belyalov <dam.bel07@gmail.com> wrote:

> There is another perl module: AdjustUpgrade.pm that is not in Makefile. Do we need it?

Yes, I think it should be installed too and skimming the linked thread I see no
mention of the omission being deliberate. I will take care of it.

> +       $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'

This is wrong though, but no need to send a new version of this small thing.

--
Daniel Gustafsson






view thread (7+ messages)  latest in thread

Message-ID: <27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org>
Permalink:  ../27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org/
Also on:    postgresql.org/message-id/27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, dam.bel07@gmail.com, peter.eisentraut@enterprisedb.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactor background psql TAP functions
  In-Reply-To: <27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox