pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: Damir Belyalov <dam.bel07@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor background psql TAP functions
Date: Fri, 19 May 2023 23:33:28 +0200
Message-ID: <2C39B660-D495-4540-B3CC-BD7BB9B37E57@postgresql.org> (raw)
In-Reply-To: <0AFDFD10-178D-44FA-86A7-0909227119D5@postgresql.org>
References: <E1pksad-001uk0-CL@gemulon.postgresql.org>
	<c0ba3008-dbc8-e53f-29f2-2e9abe72b2a2@enterprisedb.com>
	<34800305-E1E6-4194-8738-9977946DB12A@postgresql.org>
	<CALH1Lgui397s_4AXWm1ZO_uCLOUVL1HAa0TO9CbdMy1kvokkzA@mail.gmail.com>
	<27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org>
	<0AFDFD10-178D-44FA-86A7-0909227119D5@postgresql.org>

> On 17 May 2023, at 14:38, Daniel Gustafsson <dgustafsson@postgresql.org> wrote:
> 
>> On 16 May 2023, at 21:43, Daniel Gustafsson <dgustafsson@postgresql.org> wrote:
>> 
>>> On 16 May 2023, at 21:04, Damir Belyalov <dam.bel07@gmail.com> wrote:
>> 
>>> There is another perl module: AdjustUpgrade.pm that is not in Makefile. Do we need it?
>> 
>> Yes, I think it should be installed too and skimming the linked thread I see no
>> mention of the omission being deliberate. I will take care of it.
> 
> The attached is the proposed fix, which will have to be backpatched to v11 to
> match the original commit.  Unless there are reasons to treat this module
> differently from the others wrt installation I'll go ahead and fix it in time
> for beta1.

After another round of thinking I opted out of pushing this, as the module is
so tied to pg_upgrade and the regress env it's use in installed pgxs is
questionable.  While I would prefer a 1:1 between the modules in the source
tree and the installed tree, this module doesn't seem like a great fit for
installation.

--
Daniel Gustafsson






view thread (7+ messages)

Message-ID: <2C39B660-D495-4540-B3CC-BD7BB9B37E57@postgresql.org>
Permalink:  ../2C39B660-D495-4540-B3CC-BD7BB9B37E57@postgresql.org/
Also on:    postgresql.org/message-id/2C39B660-D495-4540-B3CC-BD7BB9B37E57@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, dam.bel07@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactor background psql TAP functions
  In-Reply-To: <2C39B660-D495-4540-B3CC-BD7BB9B37E57@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox