From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add pg_partition_root to display top-most parent of a partition
Date: Fri, 22 Mar 2019 13:28:19 +0900
Message-ID: <27e4501a-ae56-94e4-1524-d509f048d61c@lab.ntt.co.jp> (raw)
In-Reply-To: <20190322041225.GS20192@paquier.xyz>
References: <E1grthW-00078n-Az@gemulon.postgresql.org>
<20190322032612.GA323@alvherre.pgsql>
<20190322035538.GO20192@paquier.xyz>
<06be11a6-fd8d-b68b-1b97-1bafb1d3185c@lab.ntt.co.jp>
<20190322041225.GS20192@paquier.xyz>
On 2019/03/22 13:12, Michael Paquier wrote:
> On Fri, Mar 22, 2019 at 01:09:23PM +0900, Amit Langote wrote:
>> /* Fetch the top-most parent */
>> ancestors = get_partition_ancestors(relid);
>>
>> Maybe, the patch should update this comment to say "Fetch the list of
>> ancestors".
>
> Perhaps so. Note that actually the list is fetched to grab the
> top-most parent from it, so it sort of makes sense?
It looked fine before, but the new lines added by patch makes it look
wrong/misplaced somehow.
Thanks,
Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: Langote_Amit_f8@lab.ntt.co.jp, michael@paquier.xyz, alvherre@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add pg_partition_root to display top-most parent of a partition
In-Reply-To: <27e4501a-ae56-94e4-1524-d509f048d61c@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox