pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module
Date: Wed, 25 Jan 2023 16:50:22 -0500
Message-ID: <2848918.1674683422@sss.pgh.pa.us> (raw)
In-Reply-To: <20230125181750.GC1098626@nathanxps13>
References: <E1pKYTE-005MZS-WB@gemulon.postgresql.org>
	<CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com>
	<20230125181750.GC1098626@nathanxps13>

Nathan Bossart <nathandbossart@gmail.com> writes:
> I wanted to merge basic_archive and basic_recovery because there's a decent
> chunk of duplicated code.

Would said code likely be duplicated into non-test uses of this feature?
If so, maybe you ought to factor it out into a common location.  I agree
with Robert's point that basic_wal_module is a pretty content-free name.

			regards, tom lane





view thread (10+ messages)  latest in thread

Message-ID: <2848918.1674683422@sss.pgh.pa.us>
Permalink:  ../2848918.1674683422@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2848918.1674683422@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, robertmhaas@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module
  In-Reply-To: <2848918.1674683422@sss.pgh.pa.us>
  References: <E1pKYTE-005MZS-WB@gemulon.postgresql.org> <CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com> <20230125181750.GC1098626@nathanxps13> <2848918.1674683422@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox