pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
14+ messages / 4 participants
[nested] [flat]

* pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-21 01:53  Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 14+ messages in thread

From: Andres Freund @ 2023-11-21 01:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

meson: docs: Add {html,man} targets, rename install-doc-*

We have toplevel html, man targets in the autoconf build as well. It'd be odd
to have an 'html' target but have the install target be 'install-doc-html',
thus rename the install targets to match.

Reviewed-by: Christoph Berg <myon@debian.org>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/20231103163848.26egkh5qdgw3vmil@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ddcab2a0329511e8872b62f2c77e5fa33547c277

Modified Files
--------------
doc/src/sgml/meson.build | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-23 13:32  Andrew Dunstan <andrew@dunslane.net>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 2 replies; 14+ messages in thread

From: Andrew Dunstan @ 2023-11-23 13:32 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org


On 2023-11-20 Mo 20:53, Andres Freund wrote:
> meson: docs: Add {html,man} targets, rename install-doc-*
>
> We have toplevel html, man targets in the autoconf build as well. It'd be odd
> to have an 'html' target but have the install target be 'install-doc-html',
> thus rename the install targets to match.


This commit of one of its nearby friends appears to have broken crake's 
docs build:

ERROR: Can't invoke target `html`: ambiguous name.Add target type and/or path:
- ./doc/src/sgml/html:custom
- ./doc/src/sgml/html:alias

See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04;

cheers

andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-27 20:38  Andrew Dunstan <andrew@dunslane.net>
  parent: Andrew Dunstan <andrew@dunslane.net>
  1 sibling, 0 replies; 14+ messages in thread

From: Andrew Dunstan @ 2023-11-27 20:38 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org


On 2023-11-23 Th 08:32, Andrew Dunstan wrote:
>
>
> On 2023-11-20 Mo 20:53, Andres Freund wrote:
>> meson: docs: Add {html,man} targets, rename install-doc-*
>>
>> We have toplevel html, man targets in the autoconf build as well. It'd be odd
>> to have an 'html' target but have the install target be 'install-doc-html',
>> thus rename the install targets to match.
>
>
> This commit of one of its nearby friends appears to have broken 
> crake's docs build:
>
> ERROR: Can't invoke target `html`: ambiguous name.Add target type and/or path:
> - ./doc/src/sgml/html:custom
> - ./doc/src/sgml/html:alias
>
> See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04;
>
>

This is still broken.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-29 02:28  Andres Freund <andres@anarazel.de>
  parent: Andrew Dunstan <andrew@dunslane.net>
  1 sibling, 1 reply; 14+ messages in thread

From: Andres Freund @ 2023-11-29 02:28 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-committers@lists.postgresql.org

Hi,

On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
> On 2023-11-20 Mo 20:53, Andres Freund wrote:
> > meson: docs: Add {html,man} targets, rename install-doc-*
> >
> > We have toplevel html, man targets in the autoconf build as well. It'd be odd
> > to have an 'html' target but have the install target be 'install-doc-html',
> > thus rename the install targets to match.
>
>
> This commit of one of its nearby friends appears to have broken crake's docs
> build:
>
> ERROR: Can't invoke target `html`: ambiguous name.Add target type and/or path:
> - ./doc/src/sgml/html:custom
> - ./doc/src/sgml/html:alias
>
> See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04;

Ah, I realize now that this is from meson compile html, not 'ninja html'. That
explains why I couldn't reproduce this initially and why CI didn't complain.
I don't really understand why meson compile complains in this case.  I assume
you don't want to disambiguate as suggested, by building html:alias instead?

Greetings,

Andres Freund





^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-29 12:20  Andrew Dunstan <andrew@dunslane.net>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 3 replies; 14+ messages in thread

From: Andrew Dunstan @ 2023-11-29 12:20 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org


On 2023-11-28 Tu 21:28, Andres Freund wrote:
> Hi,
>
> On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
>> On 2023-11-20 Mo 20:53, Andres Freund wrote:
>>> meson: docs: Add {html,man} targets, rename install-doc-*
>>>
>>> We have toplevel html, man targets in the autoconf build as well. It'd be odd
>>> to have an 'html' target but have the install target be 'install-doc-html',
>>> thus rename the install targets to match.
>>
>> This commit of one of its nearby friends appears to have broken crake's docs
>> build:
>>
>> ERROR: Can't invoke target `html`: ambiguous name.Add target type and/or path:
>> - ./doc/src/sgml/html:custom
>> - ./doc/src/sgml/html:alias
>>
>> See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04;
> Ah, I realize now that this is from meson compile html, not 'ninja html'. That
> explains why I couldn't reproduce this initially and why CI didn't complain.
> I don't really understand why meson compile complains in this case.  I assume
> you don't want to disambiguate as suggested, by building html:alias instead?
>

I've done that as a temporary fix to get crake out of the hole, but it's 
pretty ugly, and I don't want to do it in a release if at all possible.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-29 13:49  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Andrew Dunstan <andrew@dunslane.net>
  2 siblings, 1 reply; 14+ messages in thread

From: Tom Lane @ 2023-11-29 13:49 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-11-28 Tu 21:28, Andres Freund wrote:
>> I don't really understand why meson compile complains in this case.  I assume
>> you don't want to disambiguate as suggested, by building html:alias instead?

> I've done that as a temporary fix to get crake out of the hole, but it's 
> pretty ugly, and I don't want to do it in a release if at all possible.

Our documentation says specifically that "ninja html" will build the
HTML format.  I would expect that to work by analogy with the "make"
target; having to spell it differently seems like clearly a bug.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-29 15:05  Andrew Dunstan <andrew@dunslane.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 14+ messages in thread

From: Andrew Dunstan @ 2023-11-29 15:05 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org


On 2023-11-29 We 08:49, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 2023-11-28 Tu 21:28, Andres Freund wrote:
>>> I don't really understand why meson compile complains in this case.  I assume
>>> you don't want to disambiguate as suggested, by building html:alias instead?
>> I've done that as a temporary fix to get crake out of the hole, but it's
>> pretty ugly, and I don't want to do it in a release if at all possible.
> Our documentation says specifically that "ninja html" will build the
> HTML format.  I would expect that to work by analogy with the "make"
> target; having to spell it differently seems like clearly a bug.
>
> 			


"ninja html" does in fact work. What's not working is "meson compile 
html". And it looks like the reason I used that in the buildfarm code is 
that ninja doesn't know about other targets like "postgres-US.pdf". Up 
to now "meson compile postgres-US.pdf html" has worked.

FWIW, the buildfarm code doesn't use ninja explicitly anywhere else.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com






^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-29 16:19  Andres Freund <andres@anarazel.de>
  parent: Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 14+ messages in thread

From: Andres Freund @ 2023-11-29 16:19 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-committers@lists.postgresql.org

Hi,

On 2023-11-29 10:05:26 -0500, Andrew Dunstan wrote:
> On 2023-11-29 We 08:49, Tom Lane wrote:
> > Andrew Dunstan <andrew@dunslane.net> writes:
> > > On 2023-11-28 Tu 21:28, Andres Freund wrote:
> > > > I don't really understand why meson compile complains in this case.  I assume
> > > > you don't want to disambiguate as suggested, by building html:alias instead?
> > > I've done that as a temporary fix to get crake out of the hole, but it's
> > > pretty ugly, and I don't want to do it in a release if at all possible.
> > Our documentation says specifically that "ninja html" will build the
> > HTML format.  I would expect that to work by analogy with the "make"
> > target; having to spell it differently seems like clearly a bug.
> > 
> > 			
> 
> 
> "ninja html" does in fact work. What's not working is "meson compile html".
> And it looks like the reason I used that in the buildfarm code is that ninja
> doesn't know about other targets like "postgres-US.pdf".

It does:

ninja help|grep pdf
  doc/src/sgml/postgres-A4.pdf  Build documentation in PDF format, with A4 pages
  doc/src/sgml/postgres-US.pdf  Build documentation in PDF format, with US letter pages

"ninja doc/src/sgml/postgres-US.pdf" works and has worked since day one.

FWIW, you can continue to use meson compile, you just need to disambiguate the
target name:
  meson compile html:alias

Which isn't particularly pretty, but does work.

Greetings,

Andres Freund





^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-11-29 18:36  Andres Freund <andres@anarazel.de>
  parent: Andrew Dunstan <andrew@dunslane.net>
  2 siblings, 1 reply; 14+ messages in thread

From: Andres Freund @ 2023-11-29 18:36 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; Tristan Partin <tristan@neon.tech>; +Cc: pgsql-hackers@lists.postgresql.org

Hi,

This started at https://www.postgresql.org/message-id/746ba786-85bb-d1f7-b613-57bec35c642a%40dunslane.net
but seems worth discussing on -hackers.

On 2023-11-29 07:20:59 -0500, Andrew Dunstan wrote:
> On 2023-11-28 Tu 21:28, Andres Freund wrote:
> > On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
> > > On 2023-11-20 Mo 20:53, Andres Freund wrote:
> > > > meson: docs: Add {html,man} targets, rename install-doc-*
> > > >
> > > > We have toplevel html, man targets in the autoconf build as well. It'd be odd
> > > > to have an 'html' target but have the install target be 'install-doc-html',
> > > > thus rename the install targets to match.
> > >
> > > This commit of one of its nearby friends appears to have broken crake's docs
> > > build:
> > >
> > > ERROR: Can't invoke target `html`: ambiguous name.Add target type and/or path:
> > > - ./doc/src/sgml/html:custom
> > > - ./doc/src/sgml/html:alias
> > >
> > > See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04;
> > Ah, I realize now that this is from meson compile html, not 'ninja html'. That
> > explains why I couldn't reproduce this initially and why CI didn't complain.
> > I don't really understand why meson compile complains in this case.  I assume
> > you don't want to disambiguate as suggested, by building html:alias instead?
> >
>
> I've done that as a temporary fix to get crake out of the hole, but it's
> pretty ugly, and I don't want to do it in a release if at all possible.

If we want to prevent these kind of conflicts, which doesn't seem
unreasonable, I think we need an automatic check that prevents reintroducing
them. I think most people will just use ninja and not see them. Meson stores
the relevant information in meson-info/intro-targets.json, so that's just a
bit of munging of that file.

I think the background for this issue existing is that meson supports a "flat"
build directory layout (which is deprecated), so the directory name can't be
used to deconflict with meson compile, which tries to work across all "build
execution" systems.

Prototype of such a check, as well as a commit deconflicting the target names,
attached.

Greetings,

Andres Freund

Attachments:

  v1-0001-meson-Rename-target-names-that-conflict-with-glob.patch (text/x-diff, 0B) download

^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-12-01 14:04  Andrew Dunstan <andrew@dunslane.net>
  parent: Andrew Dunstan <andrew@dunslane.net>
  2 siblings, 2 replies; 14+ messages in thread

From: Andrew Dunstan @ 2023-12-01 14:04 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org


On 2023-11-29 We 07:20, Andrew Dunstan wrote:
>
> On 2023-11-28 Tu 21:28, Andres Freund wrote:
>> Hi,
>>
>> On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
>>> On 2023-11-20 Mo 20:53, Andres Freund wrote:
>>>> meson: docs: Add {html,man} targets, rename install-doc-*
>>>>
>>>> We have toplevel html, man targets in the autoconf build as well. 
>>>> It'd be odd
>>>> to have an 'html' target but have the install target be 
>>>> 'install-doc-html',
>>>> thus rename the install targets to match.
>>>
>>> This commit of one of its nearby friends appears to have broken 
>>> crake's docs
>>> build:
>>>
>>> ERROR: Can't invoke target `html`: ambiguous name.Add target type 
>>> and/or path:
>>> - ./doc/src/sgml/html:custom
>>> - ./doc/src/sgml/html:alias
>>>
>>> See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04; 
>>>
>> Ah, I realize now that this is from meson compile html, not 'ninja 
>> html'. That
>> explains why I couldn't reproduce this initially and why CI didn't 
>> complain.
>> I don't really understand why meson compile complains in this case.  
>> I assume
>> you don't want to disambiguate as suggested, by building html:alias 
>> instead?
>>
>
> I've done that as a temporary fix to get crake out of the hole, but 
> it's pretty ugly, and I don't want to do it in a release if at all 
> possible.


and doing this has broken the docs build for release 16.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-12-01 17:12  Andres Freund <andres@anarazel.de>
  parent: Andrew Dunstan <andrew@dunslane.net>
  1 sibling, 0 replies; 14+ messages in thread

From: Andres Freund @ 2023-12-01 17:12 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-committers@lists.postgresql.org

Hi,


On 2023-12-01 09:04:19 -0500, Andrew Dunstan wrote:
> On 2023-11-29 We 07:20, Andrew Dunstan wrote:
> > On 2023-11-28 Tu 21:28, Andres Freund wrote:
> > > On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
> > > > On 2023-11-20 Mo 20:53, Andres Freund wrote:
> > > > > meson: docs: Add {html,man} targets, rename install-doc-*
> > > > > 
> > > > > We have toplevel html, man targets in the autoconf build as
> > > > > well. It'd be odd
> > > > > to have an 'html' target but have the install target be
> > > > > 'install-doc-html',
> > > > > thus rename the install targets to match.
> > > > 
> > > > This commit of one of its nearby friends appears to have broken
> > > > crake's docs
> > > > build:
> > > > 
> > > > ERROR: Can't invoke target `html`: ambiguous name.Add target
> > > > type and/or path:
> > > > - ./doc/src/sgml/html:custom
> > > > - ./doc/src/sgml/html:alias
> > > > 
> > > > See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04;
> > > > 
> > > Ah, I realize now that this is from meson compile html, not 'ninja
> > > html'. That
> > > explains why I couldn't reproduce this initially and why CI didn't
> > > complain.
> > > I don't really understand why meson compile complains in this case. 
> > > I assume
> > > you don't want to disambiguate as suggested, by building html:alias
> > > instead?
> > > 
> > 
> > I've done that as a temporary fix to get crake out of the hole, but it's
> > pretty ugly, and I don't want to do it in a release if at all possible.
> 
> 
> and doing this has broken the docs build for release 16.

If I can get somebody to comment on
https://postgr.es/m/20231129183619.3hrnwaexbrpygbxg%40awork3.anarazel.de
we can remove the need for the :$buildtype suffix.

Greetings,

Andres Freund





^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-12-01 19:06  Andrew Dunstan <andrew@dunslane.net>
  parent: Andrew Dunstan <andrew@dunslane.net>
  1 sibling, 0 replies; 14+ messages in thread

From: Andrew Dunstan @ 2023-12-01 19:06 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org


On 2023-12-01 Fr 09:04, Andrew Dunstan wrote:
>
> On 2023-11-29 We 07:20, Andrew Dunstan wrote:
>>
>> On 2023-11-28 Tu 21:28, Andres Freund wrote:
>>> Hi,
>>>
>>> On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
>>>> On 2023-11-20 Mo 20:53, Andres Freund wrote:
>>>>> meson: docs: Add {html,man} targets, rename install-doc-*
>>>>>
>>>>> We have toplevel html, man targets in the autoconf build as well. 
>>>>> It'd be odd
>>>>> to have an 'html' target but have the install target be 
>>>>> 'install-doc-html',
>>>>> thus rename the install targets to match.
>>>>
>>>> This commit of one of its nearby friends appears to have broken 
>>>> crake's docs
>>>> build:
>>>>
>>>> ERROR: Can't invoke target `html`: ambiguous name.Add target type 
>>>> and/or path:
>>>> - ./doc/src/sgml/html:custom
>>>> - ./doc/src/sgml/html:alias
>>>>
>>>> See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04; 
>>>>
>>> Ah, I realize now that this is from meson compile html, not 'ninja 
>>> html'. That
>>> explains why I couldn't reproduce this initially and why CI didn't 
>>> complain.
>>> I don't really understand why meson compile complains in this case.  
>>> I assume
>>> you don't want to disambiguate as suggested, by building html:alias 
>>> instead?
>>>
>>
>> I've done that as a temporary fix to get crake out of the hole, but 
>> it's pretty ugly, and I don't want to do it in a release if at all 
>> possible.
>
>
> and doing this has broken the docs build for release 16.


OK, so this code is what I have now, and seems to work on both HEAD and 
REL_16_STABLE:

         my $extra_targets = $PGBuild::conf{extra_doc_targets} || "";
         my @targs = split(/\s+/, $extra_targets);
         s!^!doc/src/sgml/! foreach @targs;
         $extra_targets=join(' ', @targs) ;
         @makeout = run_log("cd $pgsql && ninja doc/src/sgml/html $extra_targets");


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-12-01 21:55  Tristan Partin <tristan@neon.tech>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 14+ messages in thread

From: Tristan Partin @ 2023-12-01 21:55 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-hackers@lists.postgresql.org

Commits look fine to me, but I hate the new target names... Luckily, 
I just use plain ninja, so I don't interact with that.

>  +    for name, v in targets_info_byname.items():
>  +        if len(targets_info_byname[name]) > 1:

My only comment is that you could reverse the logic and save yourself an 
indentation.

- if len(targets_info_byname[name]) > 1:
+ if len(targets_info_byname[name]) <= 1:
+     continue

But whatever you want.

-- 
Tristan Partin
Neon (https://neon.tech)





^ permalink  raw  reply  [nested|flat] 14+ messages in thread

* Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
@ 2023-12-01 22:12  Andres Freund <andres@anarazel.de>
  parent: Tristan Partin <tristan@neon.tech>
  0 siblings, 0 replies; 14+ messages in thread

From: Andres Freund @ 2023-12-01 22:12 UTC (permalink / raw)
  To: Tristan Partin <tristan@neon.tech>; +Cc: Andrew Dunstan <andrew@dunslane.net>; pgsql-hackers@lists.postgresql.org

Hi,

On 2023-12-01 15:55:29 -0600, Tristan Partin wrote:
> Commits look fine to me, but I hate the new target names...

You shouldn't ever need to use them anywhere - that's what the alias is for...

Happy to go another route if you have a suggestion.


> >  +    for name, v in targets_info_byname.items():
> >  +        if len(targets_info_byname[name]) > 1:
> 
> My only comment is that you could reverse the logic and save yourself an
> indentation.
> 
> - if len(targets_info_byname[name]) > 1:
> + if len(targets_info_byname[name]) <= 1:
> +     continue
> 
> But whatever you want.

Makes sense.





^ permalink  raw  reply  [nested|flat] 14+ messages in thread


end of thread, other threads:[~2023-12-01 22:12 UTC | newest]

Thread overview: 14+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 01:53 pgsql: meson: docs: Add {html,man} targets, rename install-doc-* Andres Freund <andres@anarazel.de>
2023-11-23 13:32 ` Andrew Dunstan <andrew@dunslane.net>
2023-11-27 20:38   ` Andrew Dunstan <andrew@dunslane.net>
2023-11-29 02:28   ` Andres Freund <andres@anarazel.de>
2023-11-29 12:20     ` Andrew Dunstan <andrew@dunslane.net>
2023-11-29 13:49       ` Tom Lane <tgl@sss.pgh.pa.us>
2023-11-29 15:05         ` Andrew Dunstan <andrew@dunslane.net>
2023-11-29 16:19           ` Andres Freund <andres@anarazel.de>
2023-11-29 18:36       ` Andres Freund <andres@anarazel.de>
2023-12-01 21:55         ` Tristan Partin <tristan@neon.tech>
2023-12-01 22:12           ` Andres Freund <andres@anarazel.de>
2023-12-01 14:04       ` Andrew Dunstan <andrew@dunslane.net>
2023-12-01 17:12         ` Andres Freund <andres@anarazel.de>
2023-12-01 19:06         ` Andrew Dunstan <andrew@dunslane.net>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox