From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org, PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Record full paths of programs sought by "configure".
Date: Mon, 7 Aug 2017 15:58:02 -0400
Message-ID: <2a8e30d4-d584-1d74-6efa-100112062333@2ndQuadrant.com> (raw)
In-Reply-To: <10269.1502134598@sss.pgh.pa.us>
References: <E1dcE5n-0005Sk-UE@gemulon.postgresql.org>
<d6ca14d4-a475-6496-48b6-d9f58b29a875@2ndQuadrant.com>
<7295.1502133694@sss.pgh.pa.us>
<90c39664-ec60-77dc-9f1b-21e8fa7b864c@2ndQuadrant.com>
<10269.1502134598@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On 08/07/2017 03:36 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 08/07/2017 03:21 PM, Tom Lane wrote:
>>> I'm confused. AFAIK, that commit did not change which "prove" would
>>> be used --- at least not unless you change PATH between configure and
>>> make. It only changed how specifically that program would be named in
>>> Makefile.global. Please clarify how that broke anything.
>> That's exactly what we do. See
>> <https://github.com/PGBuildFarm/client-code/blob/master/run_build.pl; at
>> line 1649.
> My goodness, that's ugly. Is it really better than injecting
> "PROVE=prove"? (I'd suggest saying that to configure, not make,
> so that the configure log bears some resemblance to what you
> want done.)
>
>
This is what we had to do BEFORE the change in this commit. Now it's no
longer sufficient.
It would certainly be better if we could tell configure a path to prove
and a path to the perl we need to test IPC::Run against.
e.g. PROVE=/usr/bin/prove PROVE_PERL=/usr/bin/perl configure ...
The problem in all this is that we're assuming incorrectly that the perl
we use to build against is the same as the perl we need to run the build
with. On Msys that's emphatically not true.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Record full paths of programs sought by "configure".
In-Reply-To: <2a8e30d4-d584-1d74-6efa-100112062333@2ndQuadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox