From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove IS_AF_UNIX macro
Date: Wed, 16 Feb 2022 17:06:12 +0100
Message-ID: <2c53ab2c-e14d-eb00-554e-5520bdbc8d3c@enterprisedb.com> (raw)
In-Reply-To: <3047303.1644939704@sss.pgh.pa.us>
References: <E1nJtz2-0004zE-9l@gemulon.postgresql.org>
<3047303.1644939704@sss.pgh.pa.us>
On 15.02.22 16:41, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> Remove IS_AF_UNIX macro
>> The AF_UNIX macro was being used unprotected by HAVE_UNIX_SOCKETS,
>> apparently since 2008.
>
> I hadn't looked closely at this patch, but are you referring to
> this bit in ip.h?
>
> #ifdef HAVE_UNIX_SOCKETS
> #define IS_AF_UNIX(fam) ((fam) == AF_UNIX)
> #else
> #define IS_AF_UNIX(fam) (0)
> #endif
>
> That's by no means "unprotected": we will not try to reference
> AF_UNIX unless HAVE_UNIX_SOCKETS is set.
In src/backend/utils/adt/pgstatfuncs.c there is a use of AF_UNIX that
has been there unprotected by any #ifdef since about 2008.
> We might as well just nuke
> all the HAVE_UNIX_SOCKETS conditional compilation if we let
> this stand.
>
> (Now, maybe we should indeed do that. I don't have much
> interest in the possibility that we'll worry about such
> platforms in future.)
Maybe/probably. But there is a difference between platforms having the
AF_UNIX symbol (which is required by POSIX unconditionally) and
platforms actually having Unix sockets or not (which might require
different default configurations or run-time behavior), so the two
questions are not that closely connected.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Remove IS_AF_UNIX macro
In-Reply-To: <2c53ab2c-e14d-eb00-554e-5520bdbc8d3c@enterprisedb.com>
References: <E1nJtz2-0004zE-9l@gemulon.postgresql.org> <3047303.1644939704@sss.pgh.pa.us> <2c53ab2c-e14d-eb00-554e-5520bdbc8d3c@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox