From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove IS_AF_UNIX macro
Date: Wed, 16 Feb 2022 11:13:35 -0500
Message-ID: <3323700.1645028015@sss.pgh.pa.us> (raw)
In-Reply-To: <2c53ab2c-e14d-eb00-554e-5520bdbc8d3c@enterprisedb.com>
References: <E1nJtz2-0004zE-9l@gemulon.postgresql.org>
<3047303.1644939704@sss.pgh.pa.us>
<2c53ab2c-e14d-eb00-554e-5520bdbc8d3c@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 15.02.22 16:41, Tom Lane wrote:
>> I hadn't looked closely at this patch, but are you referring to
>> this bit in ip.h?
> In src/backend/utils/adt/pgstatfuncs.c there is a use of AF_UNIX that
> has been there unprotected by any #ifdef since about 2008.
Oh, I see it :-(. Poor coding, but it evidently no longer matters.
> Maybe/probably. But there is a difference between platforms having the
> AF_UNIX symbol (which is required by POSIX unconditionally) and
> platforms actually having Unix sockets or not (which might require
> different default configurations or run-time behavior), so the two
> questions are not that closely connected.
Fair point.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com
Subject: Re: pgsql: Remove IS_AF_UNIX macro
In-Reply-To: <3323700.1645028015@sss.pgh.pa.us>
References: <E1nJtz2-0004zE-9l@gemulon.postgresql.org> <3047303.1644939704@sss.pgh.pa.us> <2c53ab2c-e14d-eb00-554e-5520bdbc8d3c@enterprisedb.com> <3323700.1645028015@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox