pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove IS_AF_UNIX macro
Date: Tue, 15 Feb 2022 10:41:44 -0500
Message-ID: <3047303.1644939704@sss.pgh.pa.us> (raw)
In-Reply-To: <E1nJtz2-0004zE-9l@gemulon.postgresql.org>
References: <E1nJtz2-0004zE-9l@gemulon.postgresql.org>

Peter Eisentraut <peter@eisentraut.org> writes:
> Remove IS_AF_UNIX macro
> The AF_UNIX macro was being used unprotected by HAVE_UNIX_SOCKETS,
> apparently since 2008.

I hadn't looked closely at this patch, but are you referring to
this bit in ip.h?

#ifdef	HAVE_UNIX_SOCKETS
#define IS_AF_UNIX(fam) ((fam) == AF_UNIX)
#else
#define IS_AF_UNIX(fam) (0)
#endif

That's by no means "unprotected": we will not try to reference
AF_UNIX unless HAVE_UNIX_SOCKETS is set.  I think this change
will fail to break because we set HAVE_UNIX_SOCKETS everywhere,
but I believe it was a mistake.  We might as well just nuke
all the HAVE_UNIX_SOCKETS conditional compilation if we let
this stand.

(Now, maybe we should indeed do that.  I don't have much
interest in the possibility that we'll worry about such
platforms in future.)

			regards, tom lane





view thread (5+ messages)  latest in thread

Message-ID: <3047303.1644939704@sss.pgh.pa.us>
Permalink:  ../3047303.1644939704@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3047303.1644939704@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org
  Subject: Re: pgsql: Remove IS_AF_UNIX macro
  In-Reply-To: <3047303.1644939704@sss.pgh.pa.us>
  References: <E1nJtz2-0004zE-9l@gemulon.postgresql.org> <3047303.1644939704@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox