From: Tomas Vondra <tomas@vondra.me>
To: Jacob Champion <jacob.champion@enterprisedb.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add support for basic NUMA awareness
Date: Wed, 16 Apr 2025 20:15:13 +0200
Message-ID: <2fa11ead-c923-470e-be29-232509317904@vondra.me> (raw)
In-Reply-To: <CAOYmi+=edeujaO9AQ-JxjkWyQgcVV3v7rv2E_Mvn1GP_WN6pOw@mail.gmail.com>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
<CF6D7D7F-E1C4-45BE-9019-0F4B4BC7C135@yesql.se>
<CAOYmi+=edeujaO9AQ-JxjkWyQgcVV3v7rv2E_Mvn1GP_WN6pOw@mail.gmail.com>
On 4/16/25 18:34, Jacob Champion wrote:
> On Wed, Apr 16, 2025 at 9:30 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>> It seems like this commit didn't run autoheader, which leaves a trivial diff in
>> pg_config.h.in carried over for future callers. It doesn't change anuything
>> really as the HAVE_LIBNUMA macro isn't used, but for completeness sake we
>> should probably add it?
>
> +1, I ran autoreconf during a rebase today and had to undo the new NUMA hunks :D
>
> Your patch looks the same as what I'm carrying locally.
>
Ah, I didn't notice the autoheader thing. The patch looks fine to me.
Daniel, do you intend to push it, or do you want me to do that?
regards
--
Tomas Vondra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tomas@vondra.me, jacob.champion@enterprisedb.com, daniel@yesql.se, tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add support for basic NUMA awareness
In-Reply-To: <2fa11ead-c923-470e-be29-232509317904@vondra.me>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox