pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Introduce bloom_filter_size for BRIN bloom opclass
5+ messages / 5 participants
[nested] [flat]

Commits from this thread:
  2023-07-03 a4cfeeca5a  Fix code indentation violations
* pgsql: Introduce bloom_filter_size for BRIN bloom opclass
@ 2023-07-02 08:25 Tomas Vondra <tomas.vondra@postgresql.org>
  2023-07-03 00:22 ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 5+ messages in thread

From: Tomas Vondra @ 2023-07-02 08:25 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Introduce bloom_filter_size for BRIN bloom opclass

Move the calculation of Bloom filter parameters (for BRIN indexes) into
a separate function to make reuse easier. At the moment we only call it
from one place, but that may change and it's easier to read anyway.

Reviewed-by: Heikki Linnakangas
Discussion: https://postgr.es/m/0e1f3350-c9cf-ab62-43a5-5dae314de89c%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2b8b2852bbc54f02e26131a966e62c432144dc93

Modified Files
--------------
src/backend/access/brin/brin_bloom.c | 63 +++++++++++++++++++++++++++---------
1 file changed, 47 insertions(+), 16 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass
  2023-07-02 08:25 pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tomas Vondra <tomas.vondra@postgresql.org>
@ 2023-07-03 00:22 ` Michael Paquier <michael@paquier.xyz>
  2023-07-03 00:30   ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 5+ messages in thread

From: Michael Paquier @ 2023-07-03 00:22 UTC (permalink / raw)
  To: Tomas Vondra <tomas.vondra@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org

On Sun, Jul 02, 2023 at 08:25:34AM +0000, Tomas Vondra wrote:
> Introduce bloom_filter_size for BRIN bloom opclass
> 
> Move the calculation of Bloom filter parameters (for BRIN indexes) into
> a separate function to make reuse easier. At the moment we only call it
> from one place, but that may change and it's easier to read anyway.
> 
> Reviewed-by: Heikki Linnakangas
> Discussion: https://postgr.es/m/0e1f3350-c9cf-ab62-43a5-5dae314de89c%40enterprisedb.com

koel has failed its indent step after these commits.  I am unsure
whether you need to fix this as it does not seem that we have a
consensus to automate that, just FYI.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass
  2023-07-02 08:25 pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tomas Vondra <tomas.vondra@postgresql.org>
  2023-07-03 00:22 ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Michael Paquier <michael@paquier.xyz>
@ 2023-07-03 00:30   ` Tom Lane <tgl@sss.pgh.pa.us>
  2023-07-03 02:18     ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 1 reply; 5+ messages in thread

From: Tom Lane @ 2023-07-03 00:30 UTC (permalink / raw)
  To: Michael Paquier <michael@paquier.xyz>; +Cc: Tomas Vondra <tomas.vondra@postgresql.org>; pgsql-committers@lists.postgresql.org

Michael Paquier <michael@paquier.xyz> writes:
> koel has failed its indent step after these commits.  I am unsure
> whether you need to fix this as it does not seem that we have a
> consensus to automate that, just FYI.

Well, *somebody* has to fix it, otherwise why did we set up the animal?
But the impression I had was that a majority of committers want to
start keeping the tree pgindent-clean.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass
  2023-07-02 08:25 pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tomas Vondra <tomas.vondra@postgresql.org>
  2023-07-03 00:22 ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Michael Paquier <michael@paquier.xyz>
  2023-07-03 00:30   ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tom Lane <tgl@sss.pgh.pa.us>
@ 2023-07-03 02:18     ` Andrew Dunstan <andrew@dunslane.net>
  2023-07-03 10:54       ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tomas Vondra <tomas.vondra@enterprisedb.com>
  0 siblings, 1 reply; 5+ messages in thread

From: Andrew Dunstan @ 2023-07-03 02:18 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; Michael Paquier <michael@paquier.xyz>; +Cc: Tomas Vondra <tomas.vondra@postgresql.org>; pgsql-committers@lists.postgresql.org


On 2023-07-02 Su 20:30, Tom Lane wrote:
> Michael Paquier<michael@paquier.xyz>  writes:
>> koel has failed its indent step after these commits.  I am unsure
>> whether you need to fix this as it does not seem that we have a
>> consensus to automate that, just FYI.
> Well, *somebody* has to fix it, otherwise why did we set up the animal?
> But the impression I had was that a majority of committers want to
> start keeping the tree pgindent-clean.
>
> 			


I think we need to spell out expectations more clearly. Here's what I 
said to Tomas in a private message:

    I think the expectation is that, while there might be cases where
    you want to make some commits and then indent afterwards, so the
    changes are clear, for most cases you should try to commit
    pre-indented patches.

But that's just my opinion. I think we need to spell it out more formally.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass
  2023-07-02 08:25 pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tomas Vondra <tomas.vondra@postgresql.org>
  2023-07-03 00:22 ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Michael Paquier <michael@paquier.xyz>
  2023-07-03 00:30   ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tom Lane <tgl@sss.pgh.pa.us>
  2023-07-03 02:18     ` Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Andrew Dunstan <andrew@dunslane.net>
@ 2023-07-03 10:54       ` Tomas Vondra <tomas.vondra@enterprisedb.com>
  0 siblings, 0 replies; 5+ messages in thread

From: Tomas Vondra @ 2023-07-03 10:54 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; Tom Lane <tgl@sss.pgh.pa.us>; Michael Paquier <michael@paquier.xyz>; +Cc: Tomas Vondra <tomas.vondra@postgresql.org>; pgsql-committers@lists.postgresql.org

On 7/3/23 04:18, Andrew Dunstan wrote:
> 
> On 2023-07-02 Su 20:30, Tom Lane wrote:
>> Michael Paquier <michael@paquier.xyz> writes:
>>> koel has failed its indent step after these commits.  I am unsure
>>> whether you need to fix this as it does not seem that we have a
>>> consensus to automate that, just FYI.
>> Well, *somebody* has to fix it, otherwise why did we set up the animal?
>> But the impression I had was that a majority of committers want to
>> start keeping the tree pgindent-clean.
>>
>> 			
> 
> 
> I think we need to spell out expectations more clearly. Here's what I
> said to Tomas in a private message:
> 
>     I think the expectation is that, while there might be cases where
>     you want to make some commits and then indent afterwards, so the
>     changes are clear, for most cases you should try to commit
>     pre-indented patches.
> 
> But that's just my opinion. I think we need to spell it out more formally.
> 

I've pushed a fix for the indentation issues caused by my commits (this
one and the commit touching trigger.c). But I agree with Andrew it'd be
good to spell out the expectations - perhaps it's spelled out somewhere
deep in the pgindent, not sure.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2023-07-03 10:54 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-07-02 08:25 pgsql: Introduce bloom_filter_size for BRIN bloom opclass Tomas Vondra <tomas.vondra@postgresql.org>
2023-07-03 00:22 ` Michael Paquier <michael@paquier.xyz>
2023-07-03 00:30   ` Tom Lane <tgl@sss.pgh.pa.us>
2023-07-03 02:18     ` Andrew Dunstan <andrew@dunslane.net>
2023-07-03 10:54       ` Tomas Vondra <tomas.vondra@enterprisedb.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox