From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Beena Emerson <memissemerson@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE
Date: Tue, 06 Sep 2022 01:57:53 -0400
Message-ID: <3052113.1662443873@sss.pgh.pa.us> (raw)
In-Reply-To: <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com>
References: <20220720145220.GJ12702@telsasoft.com>
<5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> I think renumbering this makes sense. We could just leave the comment
> as is if we don't come up with a better wording.
+1, I see no need to change the comment. We just need to establish
the precedent that values within the GUC_UNIT_MEMORY field can be
chosen sequentially.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pryzby@telsasoft.com, memissemerson@gmail.com, andres@anarazel.de, pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE
In-Reply-To: <3052113.1662443873@sss.pgh.pa.us>
References: <20220720145220.GJ12702@telsasoft.com> <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com> <3052113.1662443873@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox