From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
Date: Wed, 27 Jul 2022 15:17:36 -0400
Message-ID: <3058597.1658949456@sss.pgh.pa.us> (raw)
In-Reply-To: <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql>
References: <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> Hmm, but that doesn't actually produce nice behavior. It just goes
>> into an infinite loop, like this:
>> So now I'm back to being unsure what to do here.
> I vote to go for the catversion bump for now.
What this is showing us is that any form of corruption in the relmapper
file causes very unpleasant behavior. We probably had better do something
about that, independently of this issue.
In the meantime, I still think bumping the file magic number is a better
answer. It won't make the behavior any worse for un-updated code than
it is already.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
In-Reply-To: <3058597.1658949456@sss.pgh.pa.us>
References: <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql> <3058597.1658949456@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox