From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
Date: Fri, 29 Nov 2019 17:04:45 +0100
Message-ID: <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com> (raw)
In-Reply-To: <13656.1575041267@sss.pgh.pa.us>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
<13656.1575041267@sss.pgh.pa.us>
On 2019-11-29 16:27, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> Add a regression test for allow_system_table_mods
>
> Oooh ... some of the buildfarm members are pointing out that this
> didn't follow a project convention:
Um, yes, that's why it's in unsafe_tests. Is there a way around this?
>
> @@ -153,6 +153,7 @@
> ROLLBACK;
> -- reserved tablespace name
> CREATE TABLESPACE pg_foo LOCATION '/no/such/location';
> +WARNING: tablespaces created by regression test cases should have names starting with "regress_"
> ERROR: directory "/no/such/location" does not exist
> -- triggers
> CREATE TRIGGER t1 BEFORE INSERT ON pg_description EXECUTE FUNCTION tf1();
>
> regards, tom lane
>
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
In-Reply-To: <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox