pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties.
Date: Fri, 27 Jan 2023 10:46:53 -0500
Message-ID: <3332370.1674834413@sss.pgh.pa.us> (raw)
In-Reply-To: <20230127152854.GY22427@telsasoft.com>
References: <E1pKLii-005G5B-Br@gemulon.postgresql.org>
	<20230126114659.x3yuypot7p6zj73c@alvherre.pgsql>
	<CA+TgmoYyJrOkBtFpSpVaZML-EPnG9VwSpvicj8=5Sbu647KRcQ@mail.gmail.com>
	<25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net>
	<20230126183106.GS22427@telsasoft.com>
	<Y9MZxVrCoutVbMCM@paquier.xyz>
	<3248936.1674785303@sss.pgh.pa.us>
	<Y9M/mqKqGXYt3jkC@paquier.xyz>
	<3255990.1674789499@sss.pgh.pa.us>
	<6c20449e-ac9c-7876-0d90-70a1ddea1076@dunslane.net>
	<20230127152854.GY22427@telsasoft.com>

Justin Pryzby <pryzby@telsasoft.com> writes:
> On Fri, Jan 27, 2023 at 08:27:40AM -0500, Andrew Dunstan wrote:
>> On 2023-01-26 Th 22:18, Tom Lane wrote:
>>> Maybe we need to enforce this at some other level than the tests
>>> themselves, perhaps in pg_regress?

>> Yeah, that seems like a better way to go. Then it would even apply to
>> external project tests.

> Maybe this could be done by creating a pg_dump ?

That'd be an amazingly expensive way to do it.

I was imagining that pg_regress could contain a function that
issues some predefined queries and complains if the results
aren't empty.  It already has the ability to issue commands
to the cluster-under-test (for the initial CREATE DATABASE etc)
so at least most of the infrastructure is easily at hand.

			regards, tom lane





view thread (13+ messages)  latest in thread

Message-ID: <3332370.1674834413@sss.pgh.pa.us>
Permalink:  ../3332370.1674834413@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3332370.1674834413@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pryzby@telsasoft.com, andrew@dunslane.net, michael@paquier.xyz, robertmhaas@gmail.com, alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties.
  In-Reply-To: <3332370.1674834413@sss.pgh.pa.us>
  References: <E1pKLii-005G5B-Br@gemulon.postgresql.org> <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> <CA+TgmoYyJrOkBtFpSpVaZML-EPnG9VwSpvicj8=5Sbu647KRcQ@mail.gmail.com> <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> <20230126183106.GS22427@telsasoft.com> <Y9MZxVrCoutVbMCM@paquier.xyz> <3248936.1674785303@sss.pgh.pa.us> <Y9M/mqKqGXYt3jkC@paquier.xyz> <3255990.1674789499@sss.pgh.pa.us> <6c20449e-ac9c-7876-0d90-70a1ddea1076@dunslane.net> <20230127152854.GY22427@telsasoft.com> <3332370.1674834413@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox