pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests
Date: Sun, 21 Nov 2021 10:55:42 -0500
Message-ID: <3441609.1637510142@sss.pgh.pa.us> (raw)
In-Reply-To: <57050e42-7717-3131-1704-80ce0ad4a9f2@dunslane.net>
References: <E1moZHS-0002Cu-Ei@gemulon.postgresql.org>
	<3369543.1637454364@sss.pgh.pa.us>
	<3369927.1637454743@sss.pgh.pa.us>
	<20211121003630.GA1362012@rfd.leadboat.com>
	<3371085.1637455802@sss.pgh.pa.us>
	<20211121011026.GB1362012@rfd.leadboat.com>
	<57050e42-7717-3131-1704-80ce0ad4a9f2@dunslane.net>

Andrew Dunstan <andrew@dunslane.net> writes:
> On 11/20/21 20:10, Noah Misch wrote:
>> The skip would be unnecessary if configure just tested whether $PROVE can run
>> a test requiring the module.  We're testing $PERL, but we're actually
>> indifferent to $PERL's Test::More.

> Yeah, we could do something along these lines:
> [ script ]

Seems reasonable to me, although it's not entirely clear how to hook
the output into configure's practices --- in particular, people using
"./configure -q" might not be pleased by unwanted diagnostic output.
But that could probably be dealt with.

> prove is pretty much always a script - if we want to know which perl is
> invoked we could look at its shebang line.

Do we care though?

I think the $64 question is whether it's a great idea to run the
TAP tests with a different Perl than is used for (a) build tooling
and (b) building plperl against.  I guess that it should work in
principle, and the msys animals apparently need it, but I'm
concerned that somebody will waste a lot of time being confused by
unexpected behavioral differences.  ("This works when I run a perl
script by hand, why doesn't it work in my TAP test?")  So I still
think that the best default behavior is to pick a prove associated
with the selected perl, and if you really want something other than
that then you have to set PROVE explicitly.

IOW, I think we should make (and back-patch) both of the changes
discussed in this thread.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <3441609.1637510142@sss.pgh.pa.us>
Permalink:  ../3441609.1637510142@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3441609.1637510142@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests
  In-Reply-To: <3441609.1637510142@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox