pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: psql: Add test for query canceling
Date: Tue, 24 Aug 2021 12:59:10 -0400
Message-ID: <350197.1629824350@sss.pgh.pa.us> (raw)
In-Reply-To: <9f46b102-da4d-8312-54f0-1f3bc10b453c@enterprisedb.com>
References: <E1mH14Q-0002gh-HS@gemulon.postgresql.org>
	<DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se>
	<alpine.DEB.2.22.394.2108201736060.498998@pseudo>
	<5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se>
	<1957503.1629485278@sss.pgh.pa.us>
	<9f46b102-da4d-8312-54f0-1f3bc10b453c@enterprisedb.com>

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Here is a proposal.  It waits separately for the pid file to appear and 
> also checks for the sleep query to be registered by the backend, so it 
> doesn't have any more dependencies on things happening "fast enough". 
> And it's also faster in the normal case now.  Thoughts?

That looks pretty solid to me, and I can confirm that it passes
on wrasse's host.  The only nit I can find to pick is that this:

+	usleep(10_000) until -s "$tempdir/psql.pid" or ($count++ > 180 * 100 and die 'pid file did not appear');

basically assumes that psql.pid will be written atomically.
It'd be marginally safer to wait till psql.pid can be seen to
contain a newline.  I don't think that would be too hard to do,
if you put the slurp_file call inside the wait loop and inspect
its result.

			regards, tom lane





view thread (20+ messages)  latest in thread

Message-ID: <350197.1629824350@sss.pgh.pa.us>
Permalink:  ../350197.1629824350@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/350197.1629824350@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, daniel@yesql.se, coelho@cri.ensmp.fr
  Subject: Re: pgsql: psql: Add test for query canceling
  In-Reply-To: <350197.1629824350@sss.pgh.pa.us>
  References: <E1mH14Q-0002gh-HS@gemulon.postgresql.org> <DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se> <alpine.DEB.2.22.394.2108201736060.498998@pseudo> <5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se> <1957503.1629485278@sss.pgh.pa.us> <9f46b102-da4d-8312-54f0-1f3bc10b453c@enterprisedb.com> <350197.1629824350@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox