From: Daniel Gustafsson <daniel@yesql.se>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: psql: Add test for query canceling
Date: Fri, 20 Aug 2021 20:27:32 +0200
Message-ID: <5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2108201736060.498998@pseudo>
References: <E1mH14Q-0002gh-HS@gemulon.postgresql.org>
<DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se>
<alpine.DEB.2.22.394.2108201736060.498998@pseudo>
> On 20 Aug 2021, at 17:40, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>
>
>>> psql: Add test for query canceling
>>
>> Seems sidewinder didn’t quite like this:
>
>> Nothing obvious sticks out, could it be timing related?
>
> Hmmm. Possibly, as the test is time dependent, hence the "SKIP:" section, which should mean that the test should be ignore when it fails. It seems that this part did not work. Maybe it should not state that it is expecting 2 results?
>
> use Test::More tests => 2;
>
> Replace by:
>
> use Test::More;
>
> Or something is amiss with the "SKIP" section trick?
SKIP blocks only skip tests if the condition is met, in the test as it stands
now it skips it on Windows since it requires a Unix shell:
+SKIP: {
+ skip "cancel test requires a Unix shell", 2 if $windows_os;
On all other platforms the test will execute and count towards the overall test
result of the suite.
If we want the test to run but not fail the entire test suite if it fails then
it should use a TODO block instead, but that’s intended for tests known to fail
and this doesn’t seem to fall in that category.
--
Daniel Gustafsson https://vmware.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, coelho@cri.ensmp.fr, peter.eisentraut@enterprisedb.com
Subject: Re: pgsql: psql: Add test for query canceling
In-Reply-To: <5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se>
References: <E1mH14Q-0002gh-HS@gemulon.postgresql.org> <DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se> <alpine.DEB.2.22.394.2108201736060.498998@pseudo> <5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox