From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
Date: Thu, 25 Nov 2021 23:02:49 -0500
Message-ID: <359621.1637899369@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmob32N7szLsYNyaTXgzb1rKqdWrmuwbDnZ=DXALFSbNTFg@mail.gmail.com>
References: <E1mpv7m-0007hR-QG@gemulon.postgresql.org>
<20211124231206.gbadj5bblcljb6d5@alap3.anarazel.de>
<20211125010145.fqt4mlkhzyiz4wvw@alap3.anarazel.de>
<CA+Tgmob32N7szLsYNyaTXgzb1rKqdWrmuwbDnZ=DXALFSbNTFg@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Nov 24, 2021 at 8:01 PM Andres Freund <andres@anarazel.de> wrote:
>> Pushed the obvious fix for that. Somehow thought I'd seen more compile failure
>> than the one WAL_DEBUG...
> Hmm, thanks. I guess i put too much trust in the compiler.
My approach to such patches is always "in grep we trust, all others
pay cash". Even without #ifdef issues, you are highly likely to
miss comments that need to be updated.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de
Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
In-Reply-To: <359621.1637899369@sss.pgh.pa.us>
References: <E1mpv7m-0007hR-QG@gemulon.postgresql.org> <20211124231206.gbadj5bblcljb6d5@alap3.anarazel.de> <20211125010145.fqt4mlkhzyiz4wvw@alap3.anarazel.de> <CA+Tgmob32N7szLsYNyaTXgzb1rKqdWrmuwbDnZ=DXALFSbNTFg@mail.gmail.com> <359621.1637899369@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox