pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
Date: Fri, 26 Nov 2021 17:55:17 -0800
Message-ID: <79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de> (raw)
In-Reply-To: <CA+TgmoYX_y+2XLEVoupMJ+s_NDWTZDObWeHGNM9Ao4fbAGA=5A@mail.gmail.com>
References: <E1mpv7m-0007hR-QG@gemulon.postgresql.org>
	<20211124231206.gbadj5bblcljb6d5@alap3.anarazel.de>
	<20211125010145.fqt4mlkhzyiz4wvw@alap3.anarazel.de>
	<CA+Tgmob32N7szLsYNyaTXgzb1rKqdWrmuwbDnZ=DXALFSbNTFg@mail.gmail.com>
	<359621.1637899369@sss.pgh.pa.us>
	<CA+TgmoYX_y+2XLEVoupMJ+s_NDWTZDObWeHGNM9Ao4fbAGA=5A@mail.gmail.com>

Hi, 

On November 26, 2021 5:53:31 PM PST, Andres Freund <andres@anarazel.de> wrote:
>Hi, 
>
>On November 26, 2021 7:24:15 AM PST, Robert Haas <robertmhaas@gmail.com> wrote:
>>Fortunately, it seems to have been only a minor oversight.
>
Agreed. 

I wonder if we should turn some of these ifdefs into something boiling down to if (0) { ifdef body}... No need to make it impossible for the compiler to help us in most of these cases...

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.





view thread (11+ messages)

Message-ID: <79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de>
Permalink:  ../79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de/
Also on:    postgresql.org/message-id/79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
  In-Reply-To: <79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de>
  References: <E1mpv7m-0007hR-QG@gemulon.postgresql.org> <20211124231206.gbadj5bblcljb6d5@alap3.anarazel.de> <20211125010145.fqt4mlkhzyiz4wvw@alap3.anarazel.de> <CA+Tgmob32N7szLsYNyaTXgzb1rKqdWrmuwbDnZ=DXALFSbNTFg@mail.gmail.com> <359621.1637899369@sss.pgh.pa.us> <CA+TgmoYX_y+2XLEVoupMJ+s_NDWTZDObWeHGNM9Ao4fbAGA=5A@mail.gmail.com> <79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox