pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move a comment
Date: Sat, 09 Jul 2022 11:14:25 -0400
Message-ID: <3775998.1657379665@sss.pgh.pa.us> (raw)
In-Reply-To: <E1oA8Yi-001wq1-9U@gemulon.postgresql.org>
References: <E1oA8Yi-001wq1-9U@gemulon.postgresql.org>

Peter Eisentraut <peter@eisentraut.org> writes:
> Move a comment from the to-be-deleted section of nodes.h to where it
> might still be useful.

Hm.  I'm kind of sad that we lost

-   /*
-    * TAGS FOR RANDOM OTHER STUFF
-    *
-    * These are objects that aren't part of parse/plan/execute node tree
-    * structures, but we give them NodeTags anyway for identification
-    * purposes (usually because they are involved in APIs where we want to
-    * pass multiple object types through the same pointer).
-    */

Not quite sure where that info should be put now.  Maybe nodes/README
could get another para that explains what types of objects get
treated as Nodes?

			regards, tom lane





view thread (3+ messages)  latest in thread

Message-ID: <3775998.1657379665@sss.pgh.pa.us>
Permalink:  ../3775998.1657379665@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3775998.1657379665@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org
  Subject: Re: pgsql: Move a comment
  In-Reply-To: <3775998.1657379665@sss.pgh.pa.us>
  References: <E1oA8Yi-001wq1-9U@gemulon.postgresql.org> <3775998.1657379665@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox