From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move a comment
Date: Sat, 9 Jul 2022 22:17:49 +0200
Message-ID: <1784be53-3594-6b02-7a8a-8411e2c73e27@enterprisedb.com> (raw)
In-Reply-To: <3775998.1657379665@sss.pgh.pa.us>
References: <E1oA8Yi-001wq1-9U@gemulon.postgresql.org>
<3775998.1657379665@sss.pgh.pa.us>
On 09.07.22 17:14, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> Move a comment from the to-be-deleted section of nodes.h to where it
>> might still be useful.
>
> Hm. I'm kind of sad that we lost
>
> - /*
> - * TAGS FOR RANDOM OTHER STUFF
> - *
> - * These are objects that aren't part of parse/plan/execute node tree
> - * structures, but we give them NodeTags anyway for identification
> - * purposes (usually because they are involved in APIs where we want to
> - * pass multiple object types through the same pointer).
> - */
>
> Not quite sure where that info should be put now. Maybe nodes/README
> could get another para that explains what types of objects get
> treated as Nodes?
Yeah, I looked at that comment, too, but it seemed that the particular
node types were already adequately documented at their sites. But
nodes/README seems like a good destination in general.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Move a comment
In-Reply-To: <1784be53-3594-6b02-7a8a-8411e2c73e27@enterprisedb.com>
References: <E1oA8Yi-001wq1-9U@gemulon.postgresql.org> <3775998.1657379665@sss.pgh.pa.us> <1784be53-3594-6b02-7a8a-8411e2c73e27@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox