From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Date: Wed, 30 Mar 2022 20:19:41 -0400
Message-ID: <474104.1648685981@sss.pgh.pa.us> (raw)
In-Reply-To: <E1nZaCb-00013h-2V@gemulon.postgresql.org>
References: <E1nZaCb-00013h-2V@gemulon.postgresql.org>
Andrew Dunstan <andrew@dunslane.net> writes:
> Make PostgreSQL::Test::Cluster compatible with all live branches
prairiedog is unhappy [1], seemingly as a result of this patch:
t/001_repl_stats....Can't locate parent.pm in @INC (@INC contains: ../../src/test/perl/ . /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl . /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl .) at ../../src/test/perl//PostgreSQL/Test/Cluster.pm line 2921.
BEGIN failed--compilation aborted at ../../src/test/perl//PostgreSQL/Test/Cluster.pm line 2921.
I think this means that its old Perl version misinterprets
use parent -norequire, qw(PostgreSQL::Test::Cluster);
as a request to include "parent.pm". Is there a more
backwards-compatible way to spell that?
regards, tom lane
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2022-03-30%2021%3A23%3A58
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
In-Reply-To: <474104.1648685981@sss.pgh.pa.us>
References: <E1nZaCb-00013h-2V@gemulon.postgresql.org> <474104.1648685981@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox