From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Date: Thu, 31 Mar 2022 14:18:33 -0400
Message-ID: <534ed6b2-6f25-4b0d-4159-2a7f09b61d4b@dunslane.net> (raw)
In-Reply-To: <648533.1648745441@sss.pgh.pa.us>
References: <474104.1648685981@sss.pgh.pa.us>
<393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net>
<479467.1648689140@sss.pgh.pa.us>
<230c42b8-5758-3616-b4fd-df9191f0c273@dunslane.net>
<648533.1648745441@sss.pgh.pa.us>
On 3/31/22 12:50, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> There are three ways out of this that I can see:
>> . carry a copy of parent.pm in src/test/perl (It's very small)
>> . use the older and heavier 'base' module which goes back to 5.004, and
>> does much the same thing (and a lot more)
>> . just do directly what parent.pm's import() does, as in the attached,
>> which I have tested down to version 10.
>> On the whole I think I prefer the last.
> I like #3 too, given that it's such a small patch. I've verified
> that it allows regression tests to run on perl 5.8.8, which is the
> oldest I have handy other than prairiedog's 5.8.3 (but that machine
> is tied up and I don't feel like trying to test this concurrently
> with a buildfarm run).
>
>
I think it's safe enough. Pushed.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
In-Reply-To: <534ed6b2-6f25-4b0d-4159-2a7f09b61d4b@dunslane.net>
References: <474104.1648685981@sss.pgh.pa.us> <393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net> <479467.1648689140@sss.pgh.pa.us> <230c42b8-5758-3616-b4fd-df9191f0c273@dunslane.net> <648533.1648745441@sss.pgh.pa.us> <534ed6b2-6f25-4b0d-4159-2a7f09b61d4b@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox