From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
Date: Sun, 15 Feb 2009 15:08:51 +0100
Message-ID: <499821F3.7050004@hagander.net> (raw)
In-Reply-To: <20643.1232666867@sss.pgh.pa.us>
References: <20090122100948.89F977559ED@cvs.postgresql.org>
<20643.1232666867@sss.pgh.pa.us>
Tom Lane wrote:
> mha@postgresql.org (Magnus Hagander) writes:
>> Explicitly bind gettext to the correct encoding on Windows.
>
> I have a couple of objections to this patch. First, what happens if
> it fails to find a matching table entry? (The existing answer is
> "nothing", but that doesn't seem right.) Second and more critical,
> it adds still another data structure that has to be maintained when
> the list of encodings changes, and it doesn't even live in the same
> file as any existing encoding-information table.
>
> What makes more sense to me is to add a table to encnames.c that
> provides the gettext name of every encoding that we support.
Do you mean a separate table there, or should we add a new column to one
of the existing tables?
//Magnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: magnus@hagander.net, tgl@sss.pgh.pa.us, pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
In-Reply-To: <499821F3.7050004@hagander.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox