pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
Date: Sat, 06 Nov 2021 10:30:19 -0400
Message-ID: <508673.1636209019@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-WzmGLWQWcpbwWFcm9CtSOCPuqzpN_u_VuV+jXuptgbW+hA@mail.gmail.com>
References: <E1mj0E9-0007zH-07@gemulon.postgresql.org>
	<CAH2-WzmGLWQWcpbwWFcm9CtSOCPuqzpN_u_VuV+jXuptgbW+hA@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> On Fri, Nov 5, 2021 at 7:30 AM Robert Haas <rhaas@postgresql.org> wrote:
>> Introduce 'bbstreamer' abstraction to modularize pg_basebackup.

> I'm seeing a pretty straightforward looking compiler warning following
> this commit:
> bbstreamer_file.c:564:24: warning: unused variable ‘mystreamer’

And apparently, that file isn't getting built at all on the MSVC side:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-11-06%2003%3A52%3A19

			regards, tom lane





view thread (5+ messages)  latest in thread

Message-ID: <508673.1636209019@sss.pgh.pa.us>
Permalink:  ../508673.1636209019@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/508673.1636209019@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, rhaas@postgresql.org
  Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
  In-Reply-To: <508673.1636209019@sss.pgh.pa.us>
  References: <E1mj0E9-0007zH-07@gemulon.postgresql.org> <CAH2-WzmGLWQWcpbwWFcm9CtSOCPuqzpN_u_VuV+jXuptgbW+hA@mail.gmail.com> <508673.1636209019@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox