From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
Date: Sat, 06 Nov 2021 12:17:35 -0400
Message-ID: <515458.1636215455@sss.pgh.pa.us> (raw)
In-Reply-To: <77ac2e24-051b-d57a-b02e-4dbc3306f895@enterprisedb.com>
References: <E1mj0E9-0007zH-07@gemulon.postgresql.org>
<CAH2-WzmGLWQWcpbwWFcm9CtSOCPuqzpN_u_VuV+jXuptgbW+hA@mail.gmail.com>
<508673.1636209019@sss.pgh.pa.us>
<77ac2e24-051b-d57a-b02e-4dbc3306f895@enterprisedb.com>
Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> I got annoyed by the warning so I marked the variable as assert-only.
Thanks!
> Haven't done anything about the MSVC issue.
I pushed a quick-hack fix for it. Given the ongoing meson work,
I'm not inclined to put in a lot of effort there (like teaching
the MSVC stuff about BBOBJS).
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, tomas.vondra@enterprisedb.com, pg@bowt.ie, rhaas@postgresql.org
Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
In-Reply-To: <515458.1636215455@sss.pgh.pa.us>
References: <E1mj0E9-0007zH-07@gemulon.postgresql.org> <CAH2-WzmGLWQWcpbwWFcm9CtSOCPuqzpN_u_VuV+jXuptgbW+hA@mail.gmail.com> <508673.1636209019@sss.pgh.pa.us> <77ac2e24-051b-d57a-b02e-4dbc3306f895@enterprisedb.com> <515458.1636215455@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox