From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Consistently use named parameters in regex code.
Date: Mon, 19 Sep 2022 18:18:19 -0400
Message-ID: <538126.1663625899@sss.pgh.pa.us> (raw)
In-Reply-To: <E1oaOzL-0016XZ-NN@gemulon.postgresql.org>
References: <E1oaOzL-0016XZ-NN@gemulon.postgresql.org>
Peter Geoghegan <pg@bowt.ie> writes:
> Consistently use named parameters in regex code.
Just scanning this quickly, it looks like you missed the ones
hidden behind #ifdef REG_DEBUG, eg dumpstate().
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pg@bowt.ie
Subject: Re: pgsql: Consistently use named parameters in regex code.
In-Reply-To: <538126.1663625899@sss.pgh.pa.us>
References: <E1oaOzL-0016XZ-NN@gemulon.postgresql.org> <538126.1663625899@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox