From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
Date: Mon, 20 Apr 2009 10:38:02 -0400
Message-ID: <5720.1240238282@sss.pgh.pa.us> (raw)
In-Reply-To: <49EC426F.5020602@hagander.net>
References: <20090122100948.89F977559ED@cvs.postgresql.org>
<20643.1232666867@sss.pgh.pa.us>
<499821F3.7050004@hagander.net>
<22474.1234718514@sss.pgh.pa.us>
<49D47C40.5040300@hagander.net>
<49DC7E11.2050501@enterprisedb.com>
<49EC426F.5020602@hagander.net>
Magnus Hagander <magnus@hagander.net> writes:
> Tom Lane wrote:
>>> What makes more sense to me is to add a table to encnames.c that
>>> provides the gettext name of every encoding that we support.
> Here's a patch that moves the table over to encnames.c, and renames it
> to look like the others.
I think you forgot to include the NULL terminating entry that the
loop seems to be expecting. Also, why isn't the array "const"?
> I don't know what it should be doing if it can't find a match, so I
> haven't changed that behavior.
As things stand, it should throw error, except in the case of SQL_ASCII;
there is no excuse for any other database encoding to not be in the
table. However, what seems more worrisome to me is the prospect already
discussed that the codeset name we have in the table is not actually
recognized by gettext/iconv. Did we have a solution for that?
Anyway, this fixes my immediate concern about where the info is located,
so you may as well apply it with the array-terminator fix.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, magnus@hagander.net, heikki.linnakangas@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
In-Reply-To: <5720.1240238282@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox