From: Andrew Dunstan <andrew@dunslane.net>
To: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
Date: Wed, 2 Jul 2025 15:43:02 -0400
Message-ID: <597c8ce0-12e5-4522-b8d7-eff378720085@dunslane.net> (raw)
In-Reply-To: <E1uX2BO-004OUA-2t@gemulon.postgresql.org>
References: <E1uX2BO-004OUA-2t@gemulon.postgresql.org>
On 2025-07-02 We 2:27 PM, Nathan Bossart wrote:
> Fix cross-version upgrade test breakage from commit fe07100e82.
>
> In commit fe07100e82, I renamed a couple of functions in
> test_dsm_registry to make it clear what they are testing. However,
> the buildfarm's cross-version upgrade tests run pg_upgrade with the
> test modules installed, so this caused errors like:
>
> ERROR: could not find function "get_val_in_shmem" in file ".../test_dsm_registry.so"
>
> To fix, revert those renames. I could probably get away with only
> un-renaming the C symbols, but I figured I'd avoid introducing
> function name mismatches. Also, AFAICT the buildfarm's
> cross-version upgrade tests do not run the test module tests
> post-upgrade, else we'll need to properly version the extension.
>
It doesn't really run any sanity checks at all other than amchecks.. It
just compares the pre- and post- upgrade dumps (with suitable
modifications).
So far that seems to have been enough.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
In-Reply-To: <597c8ce0-12e5-4522-b8d7-eff378720085@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox