pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Thu, 31 Mar 2022 12:45:13 -0400
Message-ID: <648071.1648745113@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmobO12W175z7MfPS1z=gQfJRzgC0vCtfb2PpgTgBqP-Cng@mail.gmail.com>
References: <20220329222504.aylyimyub6igsvpy@alap3.anarazel.de>
	<CA+hUKGLUosJyfUBT+DAN8WzTi9eqaD6-rDwnWfvfsa6mfKUcvw@mail.gmail.com>
	<684ed71e-0876-60c0-8e44-066ba702f0a6@dunslane.net>
	<CA+TgmoYf9wE56eAc5x8g33ta1GbNEAN4CcvdhDNs+Rg4OfzaHQ@mail.gmail.com>
	<20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de>
	<CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com>
	<20220330165450.3lruwky7eveddsvq@alap3.anarazel.de>
	<CA+TgmobK9EEyPpVuBs7UL_1wHkgAbFdnAkrFox6h_0-5i7HM2A@mail.gmail.com>
	<285252.1648671723@sss.pgh.pa.us>
	<CA+TgmoYgrjwh8SVPG_hiq1U4=bxj5MaR_RQ+abvO7izm94rEXQ@mail.gmail.com>
	<20220330223531.GA134543@nathanxps13>
	<472639.1648684865@sss.pgh.pa.us>
	<485495.1648692468@sss.pgh.pa.us>
	<f48f62be-56fb-7c0b-7d09-a617b5c6e64a@dunslane.net>
	<CA+TgmoZppyDsGoAYzS7+LQ9O60g9SjAu2YRUWfxLjBFohkxXfA@mail.gmail.com>
	<639823.1648740735@sss.pgh.pa.us>
	<61e2e2c0-1b1c-3b48-4d5c-2fe581e63121@dunslane.net>
	<CA+TgmobO12W175z7MfPS1z=gQfJRzgC0vCtfb2PpgTgBqP-Cng@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Mar 31, 2022 at 12:25 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>> Yeah, I think the fix is as simple as the attached.

> Well, that does not work because you added an extra parenthesis which
> makes Perl barf. If you fix that, then the test does not pass because,
> as I just explained to Tom, the flag we call --create-role doesn't
> create a role:

> error running SQL: 'psql:<stdin>:1: ERROR:  role "backupuser" does not exist'

On looking closer, the combination of --config-auth and --create-role
*only* fixes the config files for SSPI, it doesn't expect the server
to be running.

I agree that the documentation of this is nonexistent and the design
is probably questionable, but I'm not volunteering to fix either.
If you are, step right up.  In the meantime, I believe (without
having tested) that the correct incantation is to use auth_extra
but *also* create the user further down.

			regards, tom lane





view thread (66+ messages)  latest in thread

Message-ID: <648071.1648745113@sss.pgh.pa.us>
Permalink:  ../648071.1648745113@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/648071.1648745113@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andrew@dunslane.net, nathandbossart@gmail.com, andres@anarazel.de, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <648071.1648745113@sss.pgh.pa.us>
  References: <20220329222504.aylyimyub6igsvpy@alap3.anarazel.de> <684ed71e-0876-60c0-8e44-066ba702f0a6@dunslane.net> <CA+TgmoYf9wE56eAc5x8g33ta1GbNEAN4CcvdhDNs+Rg4OfzaHQ@mail.gmail.com> <20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de> <CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com> <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <CA+TgmobK9EEyPpVuBs7UL_1wHkgAbFdnAkrFox6h_0-5i7HM2A@mail.gmail.com> <285252.1648671723@sss.pgh.pa.us> <CA+TgmoYgrjwh8SVPG_hiq1U4=bxj5MaR_RQ+abvO7izm94rEXQ@mail.gmail.com> <20220330223531.GA134543@nathanxps13> <472639.1648684865@sss.pgh.pa.us> <485495.1648692468@sss.pgh.pa.us> <f48f62be-56fb-7c0b-7d09-a617b5c6e64a@dunslane.net> <CA+TgmoZppyDsGoAYzS7+LQ9O60g9SjAu2YRUWfxLjBFohkxXfA@mail.gmail.com> <639823.1648740735@sss.pgh.pa.us> <61e2e2c0-1b1c-3b48-4d5c-2fe581e63121@dunslane.net> <CA+TgmobO12W175z7MfPS1z=gQfJRzgC0vCtfb2PpgTgBqP-Cng@mail.gmail.com> <648071.1648745113@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox