From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: Thu, 9 Jan 2020 17:10:10 +0100
Message-ID: <72457f7b-4eed-c238-9e21-c113f793cf36@2ndquadrant.com> (raw)
In-Reply-To: <7656.1578585011@sss.pgh.pa.us>
References: <E1in6ft-0004zR-6l@gemulon.postgresql.org>
<20200103110128.GA28967@msg.df7cb.de>
<13708.1578059577@sss.pgh.pa.us>
<25771.1578249042@sss.pgh.pa.us>
<20200106105608.GB18560@msg.df7cb.de>
<3764.1578323719@sss.pgh.pa.us>
<20200106191303.GA3975@msg.df7cb.de>
<19973.1578351988@sss.pgh.pa.us>
<28773.1578436137@sss.pgh.pa.us>
<CA+TgmoZC_6z3d5+6n1GVfy898uoBHMPPJU4-nAQLG5ZkaEyqdQ@mail.gmail.com>
<20200109145900.GF4192@msg.df7cb.de>
<7656.1578585011@sss.pgh.pa.us>
On 2020-01-09 16:50, Tom Lane wrote:
> Christoph Berg <myon@debian.org> writes:
>> Fwiw if libedit in xenial is Just Broken and fixing the tests would
>> just codify the brokenness without adding any value, I'll just disable
>> that test in that particular build. It looks like setting
>> with_readline=no on the make command line should work.
>
> That would disable psql's tab completion, command editing, and history
> altogether, which I doubt is what you want for production builds.
> If we conclude we can't work around the testing issues for ancient
> libedit, probably the right answer is to provide a switch to
> disable just the test. I've been trying to dance around that
> conclusion, but maybe we should just do it and move on.
I think he means something like
make check with_readline=no
not for the actual build.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, myon@debian.org, robertmhaas@gmail.com, andres@anarazel.de, amit.kapila16@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
In-Reply-To: <72457f7b-4eed-c238-9e21-c113f793cf36@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox