From: Daniel Gustafsson <daniel@yesql.se>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: pgsql: Add function to pump IPC process until string match
Date: Thu, 31 Mar 2022 00:00:52 +0200
Message-ID: <72D87565-A0A6-42DC-BF0D-3C1E4AFB8237@yesql.se> (raw)
In-Reply-To: <20220330160916.vpsxtjss25yfyq3p@alap3.anarazel.de>
References: <E1nMrkR-000Hoa-VF@gemulon.postgresql.org>
<20220329225819.ahk5u2tax3ez6d2t@alap3.anarazel.de>
<E79F5248-24C2-4F48-8E10-DC592A588D79@yesql.se>
<20220330160916.vpsxtjss25yfyq3p@alap3.anarazel.de>
> On 30 Mar 2022, at 18:09, Andres Freund <andres@anarazel.de> wrote:
>> Would adding back something like the (right now untested) below be what you're
>> after? Looking at the perldoc I didn't see any other debugging aids we can
>> emit other than the stream and type of error.
>
> I found showing the regex from before useful. Often there's many
> pump_until()'s, and the regex makes it easier to figure out what errored
> out. And it shows quoting problem. Since it only happens when there was a
> failure, it's not like it'll bloat the log unduly.
I'll add diag output on failures along the lines of the diff from earlier today
but with the regex as well (which Alvarao also requested), but tomorrow morning
once coffee has been consumed.
--
Daniel Gustafsson https://vmware.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, andres@anarazel.de, michael@paquier.xyz
Subject: Re: pgsql: Add function to pump IPC process until string match
In-Reply-To: <72D87565-A0A6-42DC-BF0D-3C1E4AFB8237@yesql.se>
References: <E1nMrkR-000Hoa-VF@gemulon.postgresql.org> <20220329225819.ahk5u2tax3ez6d2t@alap3.anarazel.de> <E79F5248-24C2-4F48-8E10-DC592A588D79@yesql.se> <20220330160916.vpsxtjss25yfyq3p@alap3.anarazel.de> <72D87565-A0A6-42DC-BF0D-3C1E4AFB8237@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox