From: Joe Conway <mail@joeconway.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Move scanint8() to numutils.c
Date: Tue, 15 Feb 2022 14:00:04 -0500
Message-ID: <77f5b16f-cabd-e7e2-db9e-e3e41ff8eec6@joeconway.com> (raw)
In-Reply-To: <CA+TgmobLY=ZcvD9cLnhA92ATnEfNHgfEDM4MUCsRADH9td+mrw@mail.gmail.com>
References: <E1nJijU-0000fr-0S@gemulon.postgresql.org>
<58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com>
<CA+TgmobLY=ZcvD9cLnhA92ATnEfNHgfEDM4MUCsRADH9td+mrw@mail.gmail.com>
On 2/15/22 13:47, Robert Haas wrote:
> On Tue, Feb 15, 2022 at 10:39 AM Joe Conway <mail@joeconway.com> wrote:
>> (moving to hackers)
>>
>> I guess shame on me for not noticing the thread, but I don't see any
>> discussion about the potential for breakage to external projects.
>>
>> scanint8() is exported, and this change breaks at least two extensions I
>> maintain.
>>
>> A quick scan (no pun intended ;-)) of github shows other potential
>> breakage, including at least older (still open source) versions of
>> pglogical.
>
> I don't have a particularly strong view on whether the underlying
> change was a good idea here, but the breakage you're talking about
> seems pretty easy to fix, unless I'm missing something? I think it
> would be a bad idea to make such a change in a minor release without
> concern for extension breakage, but in a new major release it doesn't
> seem like a problem to me.
I'm not saying it is hard to fix, but it seems a bit cavalier to not
even discuss the potential for breakage. If nothing else we should flag
this as something for the release notes.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: mail@joeconway.com, robertmhaas@gmail.com, peter@eisentraut.org, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Move scanint8() to numutils.c
In-Reply-To: <77f5b16f-cabd-e7e2-db9e-e3e41ff8eec6@joeconway.com>
References: <E1nJijU-0000fr-0S@gemulon.postgresql.org> <58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com> <CA+TgmobLY=ZcvD9cLnhA92ATnEfNHgfEDM4MUCsRADH9td+mrw@mail.gmail.com> <77f5b16f-cabd-e7e2-db9e-e3e41ff8eec6@joeconway.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox