From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Cache by-reference missing values in a long lived context
Date: Fri, 25 Aug 2023 09:33:31 -0400
Message-ID: <7a219b25-b71b-f3ab-5f60-072b65e03d0d@dunslane.net> (raw)
In-Reply-To: <3979066.1692910679@sss.pgh.pa.us>
References: <E1qYvJA-000XT3-QX@gemulon.postgresql.org>
<3907902.1692890821@sss.pgh.pa.us>
<ba2150c1-8485-6597-fafe-4fcd39e49c28@dunslane.net>
<3979066.1692910679@sss.pgh.pa.us>
On 2023-08-24 Th 16:57, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net> writes:
>> On 2023-08-24 Th 11:27, Tom Lane wrote:
>>> The v11 version of this patch is causing a compiler warning for me:
>> Sorry about that, fixed.
> Thanks!
>
>> While we're about it, let's also fix these warnings which are seen on my
>> systems building releases 11 and 12:
>> /home/andrew/bf/root/REL_11_STABLE/pgsql.build/../pgsql/src/backend/commands/foreigncmds.c:481:22:
>> warning: ‘funcargtypes’ may be used uninitialized [-Wmaybe-uninitialized]
>> /home/andrew/bf/root/REL_12_STABLE/pgsql.build/../pgsql/src/backend/commands/foreigncmds.c:487:22:
>> warning: ‘funcargtypes’ may be used uninitialized [-Wmaybe-uninitialized]
>> Maybe funcargtypes here should be initialized to { 0 } ?
> Hm. It looks like we got rid of those warnings in v13 via dcb7d3caf:
>
> Author: Alvaro Herrera<alvherre@alvh.no-ip.org>
> Branch: master Release: REL_13_BR [dcb7d3caf] 2019-11-12 17:06:58 -0300
>
> Have LookupFuncName accept NULL argtypes for 0 args
>
> I'm a little tempted to propose that a better solution is to
> back-patch that patch. Removing the warning alone doesn't make
> a very strong case for that, but there are other arguments:
>
> * Somebody might back-patch code relying on the newer convention;
>
> * All else being equal, it's better to keep the code in different
> branches looking similar.
>
> I'm not sure if those arguments justify a back-patch instead of
> the localized hack you suggest.
>
>
Seems like overkill given the age of the surrounding code and the
nearness to EOL of releases 11 and 12.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Cache by-reference missing values in a long lived context
In-Reply-To: <7a219b25-b71b-f3ab-5f60-072b65e03d0d@dunslane.net>
References: <E1qYvJA-000XT3-QX@gemulon.postgresql.org> <3907902.1692890821@sss.pgh.pa.us> <ba2150c1-8485-6597-fafe-4fcd39e49c28@dunslane.net> <3979066.1692910679@sss.pgh.pa.us> <7a219b25-b71b-f3ab-5f60-072b65e03d0d@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox